fix(community): Add INSERT support to PrismaVectorStore for ParentDocumentRetriever compatibility (#8833) #8948
+167
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umentRetriever compatibility (#8833) Previously, PrismaVectorStore only used UPDATE statements when adding vectors, which caused silent failures when used with ParentDocumentRetriever. The retriever creates new child documents that don't exist in the database, so UPDATE statements would succeed but not create any records. Changes: - Add new `addDocumentsWithVectors` method that uses INSERT statements to create records - Modify `addDocuments` to use `addDocumentsWithVectors` instead of `addVectors` - Maintain backward compatibility by keeping the original `addVectors` method unchanged - Add tests to verify the new behavior and ensure no regression This fix ensures PrismaVectorStore works correctly with ParentDocumentRetriever while maintaining compatibility with existing code. Fixes #8833
🦋 Changeset detectedLatest commit: c0b26c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Add INSERT support to PrismaVectorStore for compatibility with ParentDocumentRetriever.
|
I've faced this issue. Basically, PrismaVectorStore is not usable if you're trying to store multiple chunks per document. Are there plans to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, PrismaVectorStore only used UPDATE statements when adding vectors, which caused silent failures when used with ParentDocumentRetriever. The retriever creates new child documents that don't exist in the database, so UPDATE statements would succeed but not create any records.
Changes:
addDocumentsWithVectorsmethod that uses INSERT statements to create recordsaddDocumentsto useaddDocumentsWithVectorsinstead ofaddVectorsaddVectorsmethod unchangedThis fix ensures PrismaVectorStore works correctly with ParentDocumentRetriever while maintaining compatibility with existing code.
Fixes #8833