fixed inconsistent variable naming #4096
Open
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eyurtsev
reviewed
Mar 31, 2025
| if not isinstance(text_fields, list): | ||
| raise ValueError(f"Text fields must be a list or a string. Got {text_fields}") | ||
| for p in text_fields: | ||
| fields = index_config.get("fields") or ["$"] |
There was a problem hiding this comment.
@hinthornw could you take a look the PostgresIndexConfig seems to indicate that "text_fields" is not a thing. Is this for backwards compatibility or just a typo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an inconsistency in the vector store index configuration.
According to the documentation, the expected format for a vector store index is:
However, in the Postgres vector store implementation, the parameter was named
text-fieldsinstead offields. This PR renames the parameter tofieldsto align with the documented format and maintain consistency across vector store backends.Rationale
Let me know if any additional changes are needed!