Add checkpoint_during arg #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nfcampos
commented
Apr 3, 2025
nfcampos
commented
- This provides a new mode of execution where only the last checkpoint is saved
- We save the last checkpoint no matter how the agent run is terminated (success, error, interrupt, etc)
- This cuts down on cpu time spent on checkpointing, while not losing any resilience benefits, given individual task writes are still saved
- If an error occurs and the run is retried, any tasks that completed successfully before will be skipped (as currently)
- checkpoint_during=True is useful when you want to time-travel to inner steps of a run
- The default value will remain the current behavior, ie. checkpoint_during=True
- This provides a new mode of execution where only the last checkpoint is saved - We save the last checkpoint no matter how the agent run is terminated (success, error, interrupt, etc) - This cuts down on cpu time spent on checkpointing, while not losing any resilience benefits, given individual task writes are still saved - If an error occurs and the run is retried, any tasks that completed successfully before will be skipped (as currently) - checkpoint_during=True is useful when you want to time-travel to inner steps of a run - The default value will remain the current behavior, ie. checkpoint_during=True
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hinthornw
reviewed
Apr 4, 2025
| assert (await graph.aget_state(thread)).next == ("step_2",) | ||
|
|
||
| await graph.ainvoke(None, thread, debug=True) |
There was a problem hiding this comment.
ooc: why no longer set debug=True
There was a problem hiding this comment.
Because that's just a holdover from someone debugging this test and forgetting to remove it before
hinthornw
reviewed
Apr 8, 2025
nfcampos
commented
Apr 8, 2025
| @@ -5348,6 +5433,131 @@ async def side(state: State): | |||
| assert times_called == 1 | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("checkpoint_during", [True, False]) | |||
There was a problem hiding this comment.
these tests existed only for sync case before, figured was worth adding here
hinthornw
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.