Skip to content

Fix CanContentScrollProperty.OverrideMetadata #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nice3point
Copy link
Contributor

@Nice3point Nice3point commented Apr 13, 2025

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When using plugins (run as an plugin .dll rather than an .exe), where each plugin can use wpf.ui, OverrideMetadata is called twice, which causes an exception.

image

What is the new behavior?

Added a check to disable overriding a property if it has already been done

@Nice3point Nice3point requested a review from pomianowski as a code owner April 13, 2025 13:01
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request navigation Changes to navigation related controls. dotnet release ⭐ top pull request Top pull request. labels Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet navigation Changes to navigation related controls. PR Pull request release ⭐ top pull request Top pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant