Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema.prisma #943

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update schema.prisma #943

wants to merge 5 commits into from

Conversation

NoritakaIkeda
Copy link
Member

@NoritakaIkeda NoritakaIkeda commented Mar 19, 2025

Issue

  • resolve:

Why is this change needed?

What would you like reviewers to focus on?

Testing Verification

What was done

🤖 Generated by PR Agent at a48cc5b

  • Added a new sample field to the PRCommit model in schema.prisma.
  • Enhanced the database schema for better data representation.

Detailed Changes

Relevant files
Enhancement
schema.prisma
Added `sample` field to `PRCommit` model                                 

frontend/apps/migration-web/prisma/schema.prisma

  • Added a new sample field of type String to the PRCommit model.
  • Enhanced the schema for improved data structure.
  • +2/-1     

    Additional Notes


    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @NoritakaIkeda NoritakaIkeda requested a review from a team as a code owner March 19, 2025 11:30
    @NoritakaIkeda NoritakaIkeda requested review from hoshinotsuyoshi, FunamaYukina, junkisai, MH4GF and sasamuku and removed request for a team March 19, 2025 11:30
    Copy link

    changeset-bot bot commented Mar 19, 2025

    ⚠️ No Changeset found

    Latest commit: a47ccbb

    Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

    This PR includes no changesets

    When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

    Click here to learn what changesets are, and how to add one.

    Click here if you're a maintainer who wants to add a changeset to this PR

    Copy link

    vercel bot commented Mar 19, 2025

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    liam-app 🛑 Canceled (Inspect) Apr 4, 2025 0:27am
    liam-erd-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 0:27am
    4 Skipped Deployments
    Name Status Preview Comments Updated (UTC)
    liam-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 0:27am
    test-liam-app ⬜️ Ignored (Inspect) Apr 4, 2025 0:27am
    test-liam-docs ⬜️ Ignored (Inspect) Apr 4, 2025 0:27am
    test-liam-erd-sample ⬜️ Ignored (Inspect) Apr 4, 2025 0:27am

    Copy link
    Contributor

    qodo-merge-pro-for-open-source bot commented Mar 19, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit 8289848)

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Missing Constraints

    The new sample field is added without any constraints or default value. Consider whether this field should be optional or have a default value to prevent issues with existing data.

      sample        String
    }
    Migration Impact

    Adding a required field to an existing model will require a migration strategy for existing records. Ensure there's a plan to handle existing data during migration.

      sample        String
    }

    Copy link
    Contributor

    qodo-merge-pro-for-open-source bot commented Mar 19, 2025

    PR Code Suggestions ✨

    Latest suggestions up to 8289848

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Make new field optional

    The newly added sample field lacks constraints and is required by default, which
    could break existing data. Consider making it optional or providing a default
    value to maintain backward compatibility with existing records.

    frontend/apps/migration-web/prisma/schema.prisma [183-190]

     model PRCommit {
       id            BigInt        @id @default(autoincrement()) @db.BigInt
       pullRequestId BigInt        @db.BigInt
       pullRequest   PullRequest   @relation(fields: [pullRequestId], references: [id])
       commitHash    String
       committedAt   DateTime
    -  sample        String
    +  sample        String?
     }
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a critical issue where adding a required field without a default value would break existing data. Making the field optional with the '?' modifier aligns with the schema context guidelines about not disrupting current functionality.

    High
    • More

    Previous suggestions

    Suggestions up to commit a48cc5b
    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Make new field optional

    The newly added sample field is required but doesn't have a default value. This
    could cause issues with existing data when migrating the database. Consider
    making it optional with a ? modifier or providing a default value.

    frontend/apps/migration-web/prisma/schema.prisma [183-190]

     model PRCommit {
       id            BigInt        @id @default(autoincrement()) @db.BigInt
       pullRequestId BigInt        @db.BigInt
       pullRequest   PullRequest   @relation(fields: [pullRequestId], references: [id])
       commitHash    String
       committedAt   DateTime
    -  sample        String
    +  sample        String?
     }
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a critical database migration issue. Adding a required field without a default value would cause errors for existing records, so making it optional with the '?' modifier is an important fix to prevent database migration failures.

    High
    Suggestions up to commit a48cc5b
    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Make new field optional

    The newly added sample field is required but doesn't have a default value. This
    could cause issues with existing data since all existing rows would need a value
    for this field. Consider making it optional with a ? modifier or providing a
    default value.

    frontend/apps/migration-web/prisma/schema.prisma [183-190]

     model PRCommit {
       id            BigInt        @id @default(autoincrement()) @db.BigInt
       pullRequestId BigInt        @db.BigInt
       pullRequest   PullRequest   @relation(fields: [pullRequestId], references: [id])
       commitHash    String
       committedAt   DateTime
    -  sample        String
    +  sample        String?
     }
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a critical issue with the PR. Adding a required field without a default value would cause database migration failures for existing records. Making the field optional with the '?' modifier is an appropriate solution to prevent breaking changes.

    High
    Suggestions up to commit a48cc5b
    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Make new field nullable

    The newly added sample field is missing a default value or nullable attribute.
    In Prisma, adding a non-nullable field without a default value to an existing
    model will cause migration errors for existing data.

    frontend/apps/migration-web/prisma/schema.prisma [183-190]

     model PRCommit {
       id            BigInt        @id @default(autoincrement()) @db.BigInt
       pullRequestId BigInt        @db.BigInt
       pullRequest   PullRequest   @relation(fields: [pullRequestId], references: [id])
       commitHash    String
       committedAt   DateTime
    -  sample        String
    +  sample        String?
     }
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a critical issue with the PR. Adding a non-nullable field without a default value to an existing model will cause migration errors for existing data, as the database already contains records that would violate this constraint.

    High
    Suggestions up to commit a48cc5b
    CategorySuggestion                                                                                                                                    Impact
    Possible issue
    Make new field nullable

    The newly added sample field is missing a default value or nullable attribute.
    In Prisma, adding a non-nullable field without a default value to an existing
    model will cause migration errors for existing data.

    frontend/apps/migration-web/prisma/schema.prisma [183-190]

     model PRCommit {
       id            BigInt        @id @default(autoincrement()) @db.BigInt
       pullRequestId BigInt        @db.BigInt
       pullRequest   PullRequest   @relation(fields: [pullRequestId], references: [id])
       commitHash    String
       committedAt   DateTime
    -  sample        String
    +  sample        String?
     }
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly identifies a critical issue with the PR. Adding a non-nullable field without a default value to an existing model will cause migration errors for existing data, as the database already contains records that would violate this constraint.

    High

    Copy link

    The schema change you've provided involves a modification to the PRCommit model in a Prisma schema file. Specifically, a new field named sample of type String has been added to the model. Here’s a comprehensive review of the change:

    1. Understanding the Context:
      The PRCommit model represents a commit associated with a pull request. It includes fields such as pullRequest, commitHash, and committedAt, which are essential for tracking commits in the context of pull requests. The addition of the sample field indicates an intention to store additional information related to each commit.

    2. Field Addition:
      The new sample field is of type String, which provides flexibility in what kind of data can be stored. It is crucial to understand the purpose of this field:

      • Purpose: Clarify what kind of information sample is meant to represent. Is it meant for comments, tags, or other metadata? Understanding its purpose will help ensure that the field is used appropriately in application logic.
      • Data Integrity: If the sample field holds critical information, consider implementing constraints or validations to enforce data integrity (e.g., setting it to not null if it must always contain a value).
    3. Impact on Existing Data:
      Since this is an addition rather than a modification of existing fields, it should not disrupt current data or existing functionality. However, it is essential to consider how this new field will be handled in the application:

      • Default Value: If no value is provided for sample, it will default to null, which may be acceptable. If a default value is necessary to maintain consistency, this should be explicitly defined.
    4. Migration Strategy:
      Depending on the database management system (DBMS) used, you may need to create a migration script to reflect this change in the database schema. Ensure that the migration is tested to confirm that it executes successfully without errors and that the sample field is correctly added.

    5. Documentation:
      Update any relevant documentation to include the new field, explaining its purpose, usage, and any constraints associated with it. This is vital for maintaining clarity for future developers who may interact with the schema.

    6. Testing:
      Implement unit and integration tests to ensure that the addition of the sample field does not introduce any regressions. Test scenarios where the field is populated and where it is left null to ensure that the application handles both cases gracefully.

    7. Future Considerations:
      As the application evolves, reconsider the need for the sample field. If additional attributes related to commits are anticipated in the future, it might be beneficial to evaluate whether a more structured approach (e.g., a related model) is warranted.

    In summary, the addition of the sample field to the PRCommit model is a straightforward enhancement that could provide valuable functionality, assuming its purpose is well-defined and implemented. Ensuring that proper documentation, testing, and migration strategies accompany this change will contribute to maintaining the integrity and usability of the database schema.

    Migration URL: https://liam-app-git-staging-route-06-core.vercel.app/app/projects/4/migrations/4

    @liam-migration-local
    Copy link

    liam-migration-local bot commented Mar 31, 2025

    The recent schema changes in the database design indicate a thoughtful approach towards enhancing the existing structure while considering the implications on current functionality. Below is a comprehensive review of the changes made:

    1. Documentation Context Addition:

      • The addition of documentation in docs/schemaContext emphasizes the importance of maintaining application stability when adding new fields. This is a positive step as it highlights the need for awareness regarding existing dependencies. It serves as a guideline for future schema changes, reminding developers to consider potential impacts on the application and its users.
      • The introduction of constraints for critical new fields is also a sound practice. Establishing constraints to maintain data integrity and prevent null or invalid entries is essential in ensuring that the database remains reliable and that applications can function correctly without encountering unexpected errors due to missing or incorrect data.
    2. Modification of PRCommit Model:

      • In the frontend/apps/migration-web/prisma/schema.prisma, the PRCommit model has been modified to include a new field, sample. This addition expands the model's capability, potentially allowing for richer data representation related to pull requests.
      • The inclusion of a sample field should be evaluated concerning its necessity and impact. While it can provide valuable insights, it is crucial to ensure that this field does not introduce redundancy or complexity that may complicate data management. Additionally, it’s important to consider whether this field should have any constraints or default values to maintain data integrity. If the sample field is critical for functionality, ensuring it is not nullable could prevent issues in application logic where this field is referenced.
    3. General Considerations:

      • The schema changes reflect a good practice of iterative improvement. However, it would be beneficial to include migration scripts or documentation on how existing data should be handled with the introduction of the new field. This is particularly important for databases that already have existing records, as there may be a need to populate the new field or handle it appropriately to avoid null values in production.
      • Additionally, it would be prudent to conduct thorough testing after implementing these changes. Unit tests and integration tests should be updated or created to cover new scenarios introduced by the sample field. This ensures that any changes do not inadvertently break existing functionality.
    4. Conclusion:

      • Overall, the schema changes demonstrate a proactive approach to evolving the database structure while being mindful of existing dependencies and data integrity. The emphasis on documentation and constraints is commendable and should continue to be a focal point for future modifications. As the schema evolves, continuous attention to the implications of each change on existing functionality will be key to maintaining a robust and reliable database architecture.

    Migration URL: http://localhost:3000/app/migrations/2

    @NoritakaIkeda NoritakaIkeda reopened this Mar 31, 2025
    @liam-migration-local
    Copy link

    liam-migration-local bot commented Apr 2, 2025

    Review of Schema Changes

    The recent changes to the schema involved adding a new field 'sample' to the 'PRCommit' model, along with some documentation updates. While the intention seems to enhance functionality, there are several concerns:

    Identified Issues

    1. Data Integrity: The new 'sample' field does not have any constraints, which might allow null or invalid entries. It’s crucial to establish these constraints to maintain data integrity, especially if the field is critical for some functionality.
    2. Migration Safety: Adding a field to an existing model can lead to issues if existing codebases rely on the previous structure. A thorough review of the dependencies is necessary to ensure that the new field does not disrupt current functionalities.

    Recommendations

    • For Data Integrity: Implement constraints on the 'sample' field to ensure it meets the required data quality standards. Consider making it a non-nullable field if it's essential.
    • For Migration Safety: Review all parts of the codebase that interact with the 'PRCommit' model to verify that they can accommodate the new field without causing errors or unexpected behavior.

    In conclusion, while the schema changes aim to enhance the system, proper safeguards and reviews are necessary to ensure that current functionality remains intact and data integrity is maintained.

    Migration URL: http://localhost:3000/app/migrations/1

    Copy link

    supabase bot commented Apr 4, 2025

    Updates to Preview Branch (NoritakaIkeda-patch-5) ↗︎

    Deployments Status Updated
    Database Fri, 04 Apr 2025 12:17:19 UTC
    Services Fri, 04 Apr 2025 12:17:19 UTC
    APIs Fri, 04 Apr 2025 12:17:19 UTC

    Tasks are run on every commit but only new migration files are pushed.
    Close and reopen this PR if you want to apply changes from existing seed or migration files.

    Tasks Status Updated
    Configurations Fri, 04 Apr 2025 12:17:20 UTC
    Migrations Fri, 04 Apr 2025 12:17:23 UTC
    Seeding Fri, 04 Apr 2025 12:17:23 UTC
    Edge Functions Fri, 04 Apr 2025 12:17:23 UTC

    View logs for this Workflow Run ↗︎.
    Learn more about Supabase for Git ↗︎.

    Copy link
    Contributor

    liam-migration bot commented Apr 4, 2025

    Review of Schema Changes

    The recent changes to the schema involved adding a new field 'sample' to the 'PRCommit' model, alongside some documentation updates. While the intention seems to enhance functionality, significant concerns need addressing:

    Identified Issues

    1. Data Integrity: The new 'sample' field lacks constraints, potentially allowing null or invalid entries. Establishing these constraints is crucial to ensure data integrity, especially if the field is critical for some functionality.
    2. Migration Safety: Adding a required field without a default value can lead to migration issues, particularly for existing records. A thorough review of the codebase is necessary to ensure compatibility with the new field.

    Recommendations

    • For Data Integrity: Implement constraints on the 'sample' field to enforce data quality standards. If the field is essential, consider making it non-nullable or providing a default value.
    • For Migration Safety: Review all code interacting with the 'PRCommit' model to verify it can accommodate the new field without errors or unexpected behavior. Consider making the field optional or providing a default value to mitigate potential issues.

    In conclusion, while the schema changes aim to enhance the system, proper safeguards and reviews are necessary to ensure current functionality remains intact and data integrity is preserved.

    Migration URL: https://liam-erd-web.vercel.app/app/migrations/166

    ER Diagrams:

    @liam-migration-local
    Copy link

    liam-migration-local bot commented Apr 4, 2025

    Review of Schema Changes

    The recent changes to the schema involved adding a new field 'sample' to the 'PRCommit' model. While the intention seems to enhance functionality, there are significant concerns that need addressing:

    Identified Issues

    1. Data Integrity: The new 'sample' field lacks constraints, potentially allowing null or invalid entries. Establishing these constraints is crucial to ensure data integrity, especially if the field is critical for some functionality.
    2. Migration Safety: Adding a required field without a default value can lead to migration issues, particularly for existing records. A thorough review of the codebase is necessary to ensure compatibility with the new field.

    Recommendations

    • For Data Integrity: Implement constraints on the 'sample' field to enforce data quality standards. If the field is essential, consider making it non-nullable or providing a default value.
    • For Migration Safety: Review all code interacting with the 'PRCommit' model to verify it can accommodate the new field without errors or unexpected behavior. Consider making the field optional or providing a default value to mitigate potential issues.

    In conclusion, while the schema changes aim to enhance the system, proper safeguards and reviews are necessary to ensure current functionality remains intact and data integrity is preserved.

    Migration URL: http://localhost:3000/app/migrations/1

    ER Diagrams:

    Copy link
    Contributor

    qodo-merge-pro-for-open-source bot commented Apr 4, 2025

    CI Feedback 🧐

    (Feedback updated until commit a47ccbb)

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: e2e-tests (Mobile Safari)

    Failed stage: Run e2e tests [❌]

    Failed test name: [Mobile Safari] › tests/vrt/vrt.test.ts:24:5 › top

    Failure summary:

    The action failed because the Visual Regression Test (VRT) for "top" failed in the "Mobile Safari"
    project. The test at line 25 in tests/vrt/vrt.test.ts failed because the screenshot comparison
    detected differences:

  • 3094 pixels (ratio 0.02 of all image pixels) were different between the expected and actual
    screenshots
  • The test was retried 5 times but consistently failed with the same pixel difference
  • The failure occurred at the screenshot function call at line 11:22 in the VRT test file

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    172:  ##[endgroup]
    173:  Node version file is not JSON file
    174:  Resolved ./.node-version as 22.11.0
    175:  Attempting to download 22.11.0...
    176:  Acquiring 22.11.0 - x64 from https://github.com/actions/node-versions/releases/download/22.11.0-11593095476/node-22.11.0-linux-x64.tar.gz
    177:  Extracting ...
    178:  [command]/usr/bin/tar xz --strip 1 --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/74d1e9a3-15ef-4e93-ab97-53138662fd5d -f /home/runner/work/_temp/d1c2b4eb-e76a-4158-8d2b-2efd2f395b74
    179:  Adding to the cache ...
    180:  ##[group]Environment details
    181:  node: v22.11.0
    182:  npm: 10.9.0
    183:  yarn: 1.22.22
    184:  ##[endgroup]
    185:  [command]/home/runner/setup-pnpm/node_modules/.bin/pnpm store path --silent
    186:  /home/runner/setup-pnpm/node_modules/.bin/store/v3
    187:  ##[warning]Failed to restore: Failed to GetCacheEntryDownloadURL: Received non-retryable error: Failed request: (403) Forbidden: unable to access resource in current scope
    188:  pnpm cache is not found
    ...
    
    202:  ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    203:  Progress: resolved 1721, reused 0, downloaded 147, added 146
    204:  Progress: resolved 1721, reused 0, downloaded 250, added 241
    205:  Progress: resolved 1721, reused 0, downloaded 397, added 395
    206:  Progress: resolved 1721, reused 0, downloaded 535, added 530
    207:  Progress: resolved 1721, reused 0, downloaded 562, added 554
    208:  Progress: resolved 1721, reused 0, downloaded 601, added 595
    209:  Progress: resolved 1721, reused 0, downloaded 681, added 671
    210:  Progress: resolved 1721, reused 0, downloaded 864, added 865
    211:  Progress: resolved 1721, reused 0, downloaded 978, added 979
    212:  Progress: resolved 1721, reused 0, downloaded 1216, added 1228
    213:  Progress: resolved 1721, reused 0, downloaded 1283, added 1288
    214:  Progress: resolved 1721, reused 0, downloaded 1432, added 1449
    215:  Progress: resolved 1721, reused 0, downloaded 1578, added 1586
    216:  Progress: resolved 1721, reused 0, downloaded 1703, added 1721, done
    217:  WARN  Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/node_modules/supabase/bin/supabase'
    218:  .../node_modules/core-js-pure postinstall$ node -e "try{require('./postinstall')}catch(e){}"
    219:  .../node_modules/protobufjs postinstall$ node scripts/postinstall
    220:  .../esbuild@0.25.1/node_modules/esbuild postinstall$ node install.js
    221:  .../node_modules/@depot/cli postinstall$ node install.js
    222:  .../node_modules/@biomejs/biome postinstall$ node scripts/postinstall.js
    223:  .../node_modules/core-js-pure postinstall: Done
    224:  .../esbuild@0.25.1/node_modules/esbuild postinstall: Done
    225:  .../node_modules/protobufjs postinstall: Done
    226:  .../node_modules/@biomejs/biome postinstall: Done
    227:  .../sharp@0.33.5/node_modules/sharp install$ node install/check
    228:  .../node_modules/@depot/cli postinstall: Done
    229:  .../node_modules/@prisma/engines postinstall$ node scripts/postinstall.js
    230:  .../node_modules/@sentry/cli postinstall$ node ./scripts/install.js
    231:  .../node_modules/@sentry/cli postinstall: Done
    232:  .../node_modules/@prisma/engines postinstall$ node scripts/postinstall.js
    233:  WARN  Failed to create bin at /home/runner/work/liam/liam/node_modules/.pnpm/supabase@2.15.8/node_modules/supabase/node_modules/.bin/supabase. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/node_modules/.pnpm/supabase@2.15.8/node_modules/supabase/bin/supabase'
    234:  .../node_modules/supabase postinstall$ node scripts/postinstall.js
    ...
    
    246:  .../node_modules/supabase postinstall: Installed Supabase CLI successfully
    247:  .../node_modules/supabase postinstall: Done
    248:  .../node_modules/style-dictionary postinstall$ patch-package
    249:  .../node_modules/prisma preinstall$ node scripts/preinstall-entry.js
    250:  .../node_modules/prisma preinstall: Done
    251:  .../node_modules/style-dictionary postinstall: patch-package 8.0.0
    252:  .../node_modules/style-dictionary postinstall: Applying patches...
    253:  .../node_modules/style-dictionary postinstall: No patch files found
    254:  .../node_modules/style-dictionary postinstall: Done
    255:  .../node_modules/@prisma/client postinstall$ node scripts/postinstall.js
    256:  .../node_modules/@prisma/client postinstall: prisma:warn We could not find your Prisma schema in the default locations (see: https://pris.ly/d/prisma-schema-location).
    257:  .../node_modules/@prisma/client postinstall: If you have a Prisma schema file in a custom path, you will need to run
    258:  .../node_modules/@prisma/client postinstall: `prisma generate --schema=./path/to/your/schema.prisma` to generate Prisma Client.
    259:  .../node_modules/@prisma/client postinstall: If you do not have a Prisma schema file yet, you can ignore this message.
    260:  .../node_modules/@prisma/client postinstall: Done
    261:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/packages/cli/dist-cli/bin/cli.js'
    262:  devDependencies:
    263:  + @changesets/cli 2.27.10
    264:  + @changesets/get-github-info 0.6.0
    265:  + @changesets/types 6.0.0
    266:  + @turbo/gen 2.1.2
    267:  + syncpack 13.0.0
    268:  + turbo 2.1.2
    269:  + vercel 41.4.0
    270:  frontend/apps/docs postinstall$ fumadocs-mdx
    271:  frontend/apps/docs postinstall: [MDX] types generated
    272:  frontend/apps/docs postinstall: Done
    273:  frontend/apps/app postinstall$ cp ../../packages/db-structure/node_modules/@ruby/prism/src/prism.wasm prism.wasm
    274:  frontend/apps/app postinstall: Done
    275:  WARN  Failed to create bin at /home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/.bin/liam. ENOENT: no such file or directory, open '/home/runner/work/liam/liam/frontend/apps/erd-sample/node_modules/@liam-hq/cli/dist-cli/bin/cli.js'
    276:  Done in 19.1s
    ...
    
    278:  with:
    279:  path: ~/.cache/ms-playwright
    280:  key: playwright-Linux-4eae13e04f687f8789f94b87ed7a78383da782b768a53692cd0956a990f45bfa
    281:  restore-keys: playwright-Linux-
    282:  
    283:  enableCrossOsArchive: false
    284:  fail-on-cache-miss: false
    285:  lookup-only: false
    286:  save-always: false
    287:  env:
    288:  CI: true
    289:  URL: https://liam-i5j6v7o4i-route-06-core.vercel.app
    290:  ENVIRONMENT: Preview – liam-app
    291:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
    292:  ##[endgroup]
    293:  [warning]Event Validation Error: The event type deployment_status is not supported because it's not tied to a branch or tag ref.
    294:  ##[group]Run pnpm exec playwright install --with-deps
    ...
    
    1537:  |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■        |  90% of 2.3 MiB
    1538:  |■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■■| 100% of 2.3 MiB
    1539:  FFMPEG playwright build v1011 downloaded to /home/runner/.cache/ms-playwright/ffmpeg-1011
    1540:  ##[group]Run pnpm exec playwright test --project="Mobile Safari"
    1541:  �[36;1mpnpm exec playwright test --project="Mobile Safari"�[0m
    1542:  shell: /usr/bin/bash -e {0}
    1543:  env:
    1544:  CI: true
    1545:  URL: https://liam-i5j6v7o4i-route-06-core.vercel.app
    1546:  ENVIRONMENT: Preview – liam-app
    1547:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
    1548:  ##[endgroup]
    1549:  Running 17 tests using 1 worker
    1550:  °°°·°······°°°°°×××××F
    1551:  1) [Mobile Safari] › tests/vrt/vrt.test.ts:24:5 › top ────────────────────────────────────────────
    1552:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    1553:  3094 pixels (ratio 0.02 of all image pixels) are different.
    ...
    
    1576:  12 | }
    1577:  13 |
    1578:  14 | interface TargetPage {
    1579:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
    1580:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
    1581:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
    1582:  tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png
    1583:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1584:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
    1585:  test-results/vrt-vrt-top-Mobile-Safari/top-1-actual.png
    1586:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1587:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1588:  test-results/vrt-vrt-top-Mobile-Safari/top-1-diff.png
    1589:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1590:  Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    1591:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    1592:  3094 pixels (ratio 0.02 of all image pixels) are different.
    ...
    
    1620:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
    1621:  tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png
    1622:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1623:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
    1624:  test-results/vrt-vrt-top-Mobile-Safari-retry1/top-1-actual.png
    1625:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1626:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1627:  test-results/vrt-vrt-top-Mobile-Safari-retry1/top-1-diff.png
    1628:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1629:  attachment #4: trace (application/zip) ─────────────────────────────────────────────────────────
    1630:  test-results/vrt-vrt-top-Mobile-Safari-retry1/trace.zip
    1631:  Usage:
    1632:  pnpm exec playwright show-trace test-results/vrt-vrt-top-Mobile-Safari-retry1/trace.zip
    1633:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1634:  Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    1635:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    1636:  3094 pixels (ratio 0.02 of all image pixels) are different.
    ...
    
    1659:  12 | }
    1660:  13 |
    1661:  14 | interface TargetPage {
    1662:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
    1663:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
    1664:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
    1665:  tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png
    1666:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1667:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
    1668:  test-results/vrt-vrt-top-Mobile-Safari-retry2/top-1-actual.png
    1669:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1670:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1671:  test-results/vrt-vrt-top-Mobile-Safari-retry2/top-1-diff.png
    1672:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1673:  Retry #3 ───────────────────────────────────────────────────────────────────────────────────────
    1674:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    1675:  3094 pixels (ratio 0.02 of all image pixels) are different.
    ...
    
    1698:  12 | }
    1699:  13 |
    1700:  14 | interface TargetPage {
    1701:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
    1702:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
    1703:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
    1704:  tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png
    1705:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1706:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
    1707:  test-results/vrt-vrt-top-Mobile-Safari-retry3/top-1-actual.png
    1708:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1709:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1710:  test-results/vrt-vrt-top-Mobile-Safari-retry3/top-1-diff.png
    1711:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1712:  Retry #4 ───────────────────────────────────────────────────────────────────────────────────────
    1713:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    1714:  3094 pixels (ratio 0.02 of all image pixels) are different.
    ...
    
    1737:  12 | }
    1738:  13 |
    1739:  14 | interface TargetPage {
    1740:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
    1741:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
    1742:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
    1743:  tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png
    1744:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1745:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
    1746:  test-results/vrt-vrt-top-Mobile-Safari-retry4/top-1-actual.png
    1747:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1748:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1749:  test-results/vrt-vrt-top-Mobile-Safari-retry4/top-1-diff.png
    1750:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1751:  Retry #5 ───────────────────────────────────────────────────────────────────────────────────────
    1752:  Error: �[2mexpect(�[22m�[31mpage�[39m�[2m).�[22mtoHaveScreenshot�[2m(�[22m�[32mexpected�[39m�[2m)�[22m
    1753:  3094 pixels (ratio 0.02 of all image pixels) are different.
    ...
    
    1778:  14 | interface TargetPage {
    1779:  at screenshot (/home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:11:22)
    1780:  at /home/runner/work/liam/liam/frontend/packages/e2e/tests/vrt/vrt.test.ts:25:3
    1781:  attachment #1: top-1-expected.png (image/png) ──────────────────────────────────────────────────
    1782:  tests/vrt/vrt.test.ts-snapshots/top-1-Mobile-Safari-linux.png
    1783:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1784:  attachment #2: top-1-actual.png (image/png) ────────────────────────────────────────────────────
    1785:  test-results/vrt-vrt-top-Mobile-Safari-retry5/top-1-actual.png
    1786:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1787:  attachment #3: top-1-diff.png (image/png) ──────────────────────────────────────────────────────
    1788:  test-results/vrt-vrt-top-Mobile-Safari-retry5/top-1-diff.png
    1789:  ────────────────────────────────────────────────────────────────────────────────────────────────
    1790:  Slow test file: [Mobile Safari] › tests/e2e/toolbar.test.ts (1.0m)
    1791:  Slow test file: [Mobile Safari] › tests/e2e/page.test.ts (27.8s)
    1792:  Consider running tests from slow files in parallel, see https://playwright.dev/docs/test-parallel.
    1793:  1 failed
    1794:  [Mobile Safari] › tests/vrt/vrt.test.ts:24:5 › top ─────────────────────────────────────────────
    1795:  9 skipped
    1796:  7 passed (3.0m)
    1797:  ##[error]Process completed with exit code 1.
    1798:  ##[group]Run actions/upload-artifact@v4
    ...
    
    1801:  path: frontend/packages/e2e/test-results/
    1802:  retention-days: 30
    1803:  if-no-files-found: warn
    1804:  compression-level: 6
    1805:  overwrite: false
    1806:  include-hidden-files: false
    1807:  env:
    1808:  CI: true
    1809:  URL: https://liam-i5j6v7o4i-route-06-core.vercel.app
    1810:  ENVIRONMENT: Preview – liam-app
    1811:  PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
    1812:  ##[endgroup]
    1813:  With the provided path, there will be 19 files uploaded
    1814:  Artifact name is valid!
    1815:  Root directory input is valid!
    1816:  ##[error]Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run
    1817:  Post job cleanup.
    

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant