Add binding for harmonic_integrated_from_laplacian_and_mass #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take a look at this. I'd like the naming to match C++ better. Probably in C++ |
|
@alecjacobson, any chance this PR could get reviewed and merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Was updating some dependencies for a project and noticed that 'harmonic_integrated_from_laplacian_and_mass' was missing from the new bindings, so I've added it here (with a basic unit test). I've kept it as the same name in the docs (rather than overloading 'harmonic' like the c++ does for consistency with past versions), but happy to change it.