Add chain_anchor with block_timestamp to AssetLeaves RPC #1480
Conversation
rpcserver.go
Outdated
| // Ensure block timestamp is set for on-chain assets. | ||
| if rpcAsset.ChainAnchor != nil && | ||
| rpcAsset.ChainAnchor.BlockHeight != 0 && | ||
| rpcAsset.ChainAnchor.BlockTimestamp == 0 { | ||
|
|
||
| ts := r.cfg.ChainBridge.GetBlockTimestamp( | ||
| ctx, | ||
| rpcAsset.ChainAnchor.BlockHeight, | ||
| ) | ||
| rpcAsset.ChainAnchor.BlockTimestamp = ts | ||
| } |
There was a problem hiding this comment.
This block doesn't feel quite right here, but I added it because I saw that the block_timestamp field was 0 when running tapcli assets list. I didn't see how to grab the timestamp from within the assets store dbAssetsToChainAssets function since it isn't stored in the DB. I didn't feel like it would be appropriate to somehow call ChainBridge.GetBlockTimestamp() from the db level. Please let me know if there's a better way to do this.
There was a problem hiding this comment.
I didn't see how to grab the timestamp from within the assets store dbAssetsToChainAssets function since it isn't stored in the D
Yeah the timestamp isn't stored in the DB, as we only store the transaction and not also the header.
However the header is stored in the proof.Proof struct, which is a state transition proof (new txn properly followed all the rules). Looks like you start to decode the proof below here in the diff, so you should be able to get the header, then the timestamp from that.
There was a problem hiding this comment.
Lines 243 to 246 in db28a03
There was a problem hiding this comment.
There was a problem hiding this comment.
Nice! I was able to fetch the proof and grab the timestamp from the block header. Thanks for the pointer. This implementation feels much better.
There was a problem hiding this comment.
Eww! Looks like this change broke some of the tests. Going to try to resolve those issues.
Pull Request Test Coverage Report for Build 14645961836Details
💛 - Coveralls |
jamaljsr
force-pushed
the
leaves-chain-anchor
branch
3 times, most recently
from
50e0937 to
55496e8
Compare
jamaljsr
force-pushed
the
leaves-chain-anchor
branch
2 times, most recently
from
7b6367e to
5130af8
Compare
This adds a new `AnchorBlockTimestamp` field to the `ChainAsset` struct which gets set to the timestamp of the block header encoded in the `Proof`.
Add a `block_timestamp` field to the `AnchorInfo` RPC message which will contain the Unix timestamp of the block containing the anchor transaction
When marshalling a chain asset, ensure the block timestamp is set. This is needed for assets fetched from the DB since the timestamp is not stored in the table with the asset.
jamaljsr
force-pushed
the
leaves-chain-anchor
branch
from
5130af8 to
ba859b9
Compare
Closes #1477
We would like to update Terminal to display all of the asset mints/burns for a group key. We also want to display the txid and timestamp of the mint txn. I'm using the universe
AssetLeavesRPC to get the list of issued assets. This is when I realized that thechain_anchorfield was not being set in this response.I have taken a stab at implementing the fix to include the
chain_anchorfield in theAssetLeavesRPC response. I updatedmarshalAssetLeafto callMarshalChainAssetwhich includes the chain anchor info. I also added a newblock_timestampfield to the RPC message, which gets set from the block header which is encoded in the proof.Note: This is my first contribution to this repo and would appreciate any guidance on whether the approach I've taken here is good. There may be better ways to get the desired result which I have not discovered yet.