Skip to content

rpcserver+taprpc: add issuance reveal data to proof leaf #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guggero
Copy link
Member

@guggero guggero commented Apr 24, 2025

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 14646658529

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 221 (2.26%) changed or added relevant lines in 2 files are covered.
  • 40 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.007%) to 28.693%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcserver.go 0 44 0.0%
taprpc/universerpc/universe.pb.go 5 177 2.82%
Files with Coverage Reduction New Missed Lines %
asset/group_key.go 2 57.89%
commitment/tap.go 2 71.36%
tapchannel/aux_leaf_signer.go 3 43.43%
asset/mock.go 6 64.86%
tapdb/multiverse.go 6 53.03%
asset/asset.go 21 48.07%
Totals Coverage Status
Change from base Build 14638699557: -0.007%
Covered Lines: 26732
Relevant Lines: 93165

💛 - Coveralls

@jamaljsr
Copy link
Member

Thanks for the update! I tested this on regtest and it meets my needs of returning the metadata for a given asset_id/group_key. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants