Merge pull request #7 from lilyvanoekel/issue/1

Fix clicking on voice stealing add test workflow

.github/workflows/run-tests.yaml

@@ -0,0 +1,27 @@
+name: Run Tests
+
+on:
+  pull_request:
+    branches:
+      - main
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20.x"
+
+      - name: Install dependencies
+        working-directory: ./view
+        run: npm ci
+
+      - name: Run tests
+        working-directory: ./view
+        run: npm test -- --run

dsp/Common/ADSR.cmajor

@@ -35,7 +35,6 @@ namespace Common
             sustainLevel = max(minimumLevel, sustain);
         }
 
-        // @todo: fix issue with long release times and plops
         event release (float release) {
             releaseSeconds = max(0.01f, release);
         }
@@ -79,7 +78,7 @@ namespace Common
 
                 // Attack
                 int32 attackSamples = int32(attackSeconds * float32(processor.frequency));
-                currentLevel = minimumLevel;
+                currentLevel = max(minimumLevel, currentLevel);
                 float target = keyDownVelocity;
                 float stepSize = 0.0f;
 
@@ -137,7 +136,7 @@ namespace Common
                     advance();
                 }
 
-                gainOut <- 0;
+                gainOut <- currentLevel;
                 advance();
             }
         }