Skip to content

Support: limactl disk import command #3439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Support: limactl disk import command #3439

merged 1 commit into from
Apr 30, 2025
+66 −0

Conversation

songponssw
Copy link
Contributor

@songponssw songponssw commented Apr 17, 2025 •
edited
Loading

Split PR from #3437
Support disk command to add an existing disk to Lima.

Feedback from #3437 PR

Cobra command

  • Fix syntax on Use
  • Edit Short description
  • Passing as argument instead of using flags
  • Alias add/import

diskAddAction()

  • Check diskName already taken.
  • Use contfs.CopyFile
  • Edit log message

@songponssw songponssw mentioned this pull request Apr 17, 2025
Draft
AkihiroSuda
AkihiroSuda reviewed Apr 18, 2025
View reviewed changes
AkihiroSuda
AkihiroSuda reviewed Apr 18, 2025
View reviewed changes
@AkihiroSuda
Copy link
Member

Is this still draft?

@AkihiroSuda
Copy link
Member

Please squash the commits and fix the PR title

@songponssw songponssw force-pushed the feat-add-disk branch 2 times, most recently from 4ec2d30 to 8da98a3 Compare April 18, 2025 01:54
@songponssw songponssw changed the title Support: limactl disk add command Support: limactl disk import command Apr 18, 2025
@songponssw songponssw marked this pull request as ready for review April 18, 2025 01:57
@songponssw
Copy link
Contributor Author

Thanks for your suggestion @AkihiroSuda - I've updated the PR name.
It's ready for review.

@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Apr 18, 2025
@AkihiroSuda AkihiroSuda added the area/cli limactl CLI user experience label Apr 18, 2025
AkihiroSuda
AkihiroSuda previously approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

AkihiroSuda
AkihiroSuda reviewed Apr 18, 2025
View reviewed changes
@songponssw
support: limactl disk import command
3052ef8 
Signed-off-by: Songpon Srisawai <songpon.ssw@gmail.com>
@AkihiroSuda AkihiroSuda requested a review from a team April 21, 2025 01:14
AkihiroSuda
AkihiroSuda approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 3fea800 into lima-vm:master Apr 30, 2025
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/cli limactl CLI user experience
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@songponssw @AkihiroSuda