Write (deferred) headers #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike `ResponseWriter.Write`, `io.Copy` doesn't add the deferred
headers. Deferred headers are applied _after_ the proxied response.
This (not standalong) is CORS configuration, for example, that only
works with the change.
```Caddyfile
header {
Access-Control-Allow-Origin "{re.origin.0}"
Access-Control-Allow-Credentials true
Access-Control-Expose-Headers "{args[1]}"
Vary Origin
defer
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike
ResponseWriter.Write,io.Copydoesn't add the deferred headers. Deferred headers are applied after the proxied response.This (not standalong) is CORS configuration, for example, that only works with the change.
Fixes #65 (though I suppose there may be issues with PUT and DELETE, too).
(Edit: PUT and, probably, DELETE, are affected, too — this can be merged as is, but if I fix PUT and DELETE beforehand I'll add to this PR.)