Support hints via jdbc connection properties #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is to add a hints KV field to the jdbc connection properties. This allows users to side-load hints. Ideally, users would be able to pass hints through the SQL itself see here but Calcite does not support hints on materialized views.
I did explore a separate path of being able to list all hints through SQL on the SELECT statement however I don't think this solution is any better: main...jogrogan/hints
This change is kept pretty simple so that we can change it in the future should we want to go with the above solution or should we want to have separate hints for sources/sinks/jobs.
List of changes: