Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hints via jdbc connection properties #116

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Conversation

jogrogan
Copy link
Collaborator

@jogrogan jogrogan commented Feb 26, 2025

The main change in this PR is to add a hints KV field to the jdbc connection properties. This allows users to side-load hints. Ideally, users would be able to pass hints through the SQL itself see here but Calcite does not support hints on materialized views.

I did explore a separate path of being able to list all hints through SQL on the SELECT statement however I don't think this solution is any better: main...jogrogan/hints

This change is kept pretty simple so that we can change it in the future should we want to go with the above solution or should we want to have separate hints for sources/sinks/jobs.

List of changes:

  • Add hints to Sink & JobDeployer, still working on adding it to the connector deployer (will come in a separate PR)
  • Fixed bug with PipelineReconciler throwing exception on deletion
  • Expanded README
  • Fixed checkstyle complaints

Copy link
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This makes sense to me, and jibes well with our internal tooling. Hopefully I didn't step too hard on this PR with my last one :)

@jogrogan jogrogan force-pushed the jogrogan/hintpassthrough branch from 965c6e0 to 8bab18f Compare February 26, 2025 17:18
@jogrogan jogrogan merged commit 8f5f195 into main Feb 26, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/hintpassthrough branch February 26, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants