Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing rules for LISTAGG & UNNEST #118

Merged
merged 2 commits into from
Feb 27, 2025
Merged

Add missing rules for LISTAGG & UNNEST #118

merged 2 commits into from
Feb 27, 2025

Conversation

jogrogan
Copy link
Collaborator

@jogrogan jogrogan commented Feb 27, 2025

SQL functions were still not fully working with #112. The tests were only testing views, creation of materialized views, when walking the implementor path, uncovered a few issues.

  • Added LogicAggregate rule to support LISTAGG
  • Added Uncollect rule to support UNNEST

There are still feature gaps present

create or replace view ADS."unnested" AS SELECT * FROM UNNEST(ARRAY(SELECT "FIRST_NAME" FROM profile.members)) AS name;

This still fails expected rules for Collect and LogicalValues. Hit a roadblock with Collect which is missing RelToSqlConverter conversion so gave up on that for now.

Copy link
Collaborator

@ryannedolan ryannedolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jogrogan jogrogan merged commit 279b3d4 into main Feb 27, 2025
1 check passed
@jogrogan jogrogan deleted the jogrogan/rules branch February 27, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants