Add missing rules for LISTAGG & UNNEST #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL functions were still not fully working with #112. The tests were only testing views, creation of materialized views, when walking the implementor path, uncovered a few issues.
LogicAggregate
rule to support LISTAGGUncollect
rule to support UNNESTThere are still feature gaps present
This still fails expected rules for
Collect
andLogicalValues
. Hit a roadblock withCollect
which is missingRelToSqlConverter
conversion so gave up on that for now.