Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid hints from Properties inputs. #119

Merged
merged 2 commits into from
Mar 1, 2025
Merged

Conversation

ehoner
Copy link
Collaborator

@ehoner ehoner commented Feb 28, 2025

Validate contents of Properties object used for "hints". This is related to an issue (error below) reported by clients after deploying #117. The expected use of the "hints" and "pipeline" options are unchanged. The unit test validate the following conditions:

  1. An empty "hints" map is ignored.
  2. Non-empty "hints" are valid as either key value pairs or flags.
  3. Parsing of "pipeline" occurs regardless of "hints" (no collision detection).

The input Properties parameter for parseHints included a "hints" key with an empty value.

Caused by: java.lang.IllegalArgumentException: Chunk [] is not a valid entry
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:218) ~[com.google.guava.guava-33.3.1-jre.jar:?]
        at com.google.common.base.Splitter$MapSplitter.split(Splitter.java:523) ~[com.google.guava.guava-33.3.1-jre.jar:?]
        at com.linkedin.hoptimator.util.DeploymentService.parseHints(DeploymentService.java:100) ~[com.linkedin.hoptimator.hoptimator-util-0.0.37-alpha.jar:?]
        at com.linkedin.hoptimator.util.DeploymentService.plan(DeploymentService.java:90) ~[com.linkedin.hoptimator.hoptimator-util-0.0.37-alpha.jar:?]
...

@ehoner ehoner merged commit 3fa0e59 into main Mar 1, 2025
1 check passed
@ehoner ehoner deleted the ehoner/hint-fix branch March 1, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants