Skip to content

Unmark Z220 as untested #1972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Unmark Z220 as untested #1972

wants to merge 1 commit into from

Conversation

d-wid
Copy link
Contributor

@d-wid d-wid commented May 13, 2025

Context: #1908

Apologies again for missing the test that led to my board being untested for many weeks. If you happen to at some point see it as a good idea to make it "tested" again here's a PR that can be merged to make it so.

Although, seeing as my board isn't labelled "unmaintained", am I right in assuming it's still being maintained anyway? I do find that worth more than the (un)tested label, fwiw.

It goes without saying you might want to see if I can reasonably I keep up in the future in a few rounds of testing testing-needed PRs before merging this.

@tlaurion
Copy link
Collaborator

tlaurion commented May 14, 2025

Hey @d-wid :

  • signed-off commits and DCO testing error of this PR: please read https://github.com/linuxboot/heads/blob/master/CONTRIBUTING.md#for-pull-requests
  • Moving boards from testing to untested and vice versa: use Main Makefile's board.move_untested_to_tested helper

    heads/Makefile

    Line 894 in 13f55f4

    board.move_untested_to_tested:
    • That is, ./docker_repro.sh make BOARD=UNTESTED_XYZ board.move_untested_to_tested that was created to make this easier in situation exactly like this in the future; the tester needing to be able to move boards back to tested in a PR on their own timelines

The board having been moved to untested was under this commit: 382949d

Commit log said:

z220-cmt boards: move to untested with board.move_tested_to_untested helper, per notice at #1908 (comment)
Unfortunately the helper doesn't deal well with board inclusion: sed call is imperfect, and board config needs to be manually edited.

So in a perfect world, all boards would be tested in time and code redundancy would not be a problem in that case, but since we need to move boards back from tested to untested to unmaintained and abck and forth, @d-wid please remove board inclusion within each other (duplicate the whole entries making hotp board include HOTP being the only difference) so that moving this platform to untested/unmaintained becomes easy (as intended) in the future).

Where #1908 (comment) said:

Of all boards needing testing in OP(modified)


Notes:

  • this board is, AFAIK, only owned and used by you so you are kind of its maintainer, where my role for that board is to make sure that all code/config changes related to boards of the same CPU family/platform were applied on UNTESTED boards
  • This is peculiar situation, where a board that is "supported" aka "maintained" should be used by multiple people to be a sustainable maintained effort over time.
  • Here, minimally, putting this board back to tested (not UNTESTED) would mean that it won't brick when internally flashing. But for the rest, you would have to test features that were added since that board was moved to untested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants