[ConvertToArcs] Add llhd.combinational conversion #8950
Conversation
fabianschuiki
force-pushed
the
fschuiki/arc-llhd-combinational
branch
2 times, most recently
from
bf81909 to
ac154f1
Compare
fabianschuiki
force-pushed
the
fschuiki/arc-execute
branch
2 times, most recently
from
a8437ac to
8c75ba9
Compare
fabianschuiki
force-pushed
the
fschuiki/arc-llhd-combinational
branch
from
ac154f1 to
1625508
Compare
Introduce a dialect conversion step into the `ConvertToArcs` pass. We'll use this to map various core dialect operations to Arc-specific ones in the future. As a starting point, add a conversion from `llhd.combinational` to `arc.execute`. This, alongside lowering to LLVM to be added in later PRs, will implement some basic LLHD support in the Arc dialect.
fabianschuiki
force-pushed
the
fschuiki/arc-llhd-combinational
branch
from
1625508 to
078d3f1
Compare
| target.markUnknownOpDynamicallyLegal( | ||
| [](Operation *op) { return !isa<llhd::LLHDDialect>(op->getDialect()); }); |
There was a problem hiding this comment.
Is it required even when llhd::LHDDialect is registered as an illegal dialect?
There was a problem hiding this comment.
Yeah I ran into the issue that all operations/dialects not explicitly listed as legal leading to a "failed to legalize" error. I would have thought that the partial dialect conversion would just rewrite ops that were explicitly marked as illegal. But that didn't work for me 🤔
There was a problem hiding this comment.
Hmm, interesting! Thank you for trying it out!
There was a problem hiding this comment.
One of the reasons I often just use greedy pattern rewriter or simple walk, as I always have to remember again and mostly I want any pattern that can apply to apply. (dialect conversion still very useful for ones where type conversion needed and I haven't tried the new oneshot one).
There was a problem hiding this comment.
Yeah same here. I have no mental model of the dialect conversion framework. It feels completely random to me what I have to put into legalization, type conversion, and what gets converted where. But the plain old rewriting framework is annoying when a lot of type conversions are involved. I'm also having trouble finding good documentation for the dialect conversion framework. Seems to be a RTFC kind of deal 😁
Introduce a dialect conversion step into the
ConvertToArcspass. We'll use this to map various core dialect operations to Arc-specific ones in the future. As a starting point, add a conversion fromllhd.combinationaltoarc.execute. This, alongside lowering to LLVM to be added in later PRs, will implement some basic LLHD support in the Arc dialect.