-
Notifications
You must be signed in to change notification settings - Fork 168
[CIR] Implement virtual destructor call #1856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bcardosolopes
merged 12 commits into
llvm:main
from
ahmedshakill:virtual-destructor-call
Sep 3, 2025
Merged
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5d589cd
virtual destructor explicit unqualified call
ahmedshakill d1ca84d
fix formatting
ahmedshakill 1e96dcc
follow coding guideline
ahmedshakill c9c9e9c
make checks less hard coded
ahmedshakill 45b5109
make test more readable and consistent
ahmedshakill d89a8f0
add 'else' accompanying the 'if'
ahmedshakill db228e9
remove redundant check
ahmedshakill 9236e41
use existing emitVirtualDestructorCall
ahmedshakill 6bdbd0b
add cir-llvm and og-llvm test
ahmedshakill 83f2d3d
name values properly
ahmedshakill 80ddca7
rename this and dtor variables
ahmedshakill d6d6daa
add 'store %this' in cir test
ahmedshakill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
clang/test/CIR/CodeGen/virtual-destructor-explicit-unqualified-call.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -std=c++20 -fclangir -emit-cir %s -o %t.cir | ||
// RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s | ||
|
||
|
||
class A { | ||
virtual ~A(); | ||
A B(A); | ||
}; | ||
A A::B(A) { | ||
// CIR-LABEL: cir.func dso_local @_ZN1A1BES_( | ||
// CIR-SAME: %[[THIS_ARG:.*]]: !cir.ptr<!rec_A> | ||
// CIR-NEXT: %[[THIS_VAR:.*]] = cir.alloca !cir.ptr<!rec_A>, !cir.ptr<!cir.ptr<!rec_A>> | ||
ahmedshakill marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// CIR: %[[THIS:.*]] = cir.load %[[THIS_VAR]] : !cir.ptr<!cir.ptr<!rec_A>>, !cir.ptr<!rec_A> | ||
// CIR-NEXT: %[[VPTR_PTR:.*]] = cir.vtable.get_vptr %[[THIS]] : !cir.ptr<!rec_A> -> !cir.ptr<!cir.vptr> | ||
// CIR-NEXT: %[[VPTR:.*]] = cir.load align(8) %[[VPTR_PTR]] : !cir.ptr<!cir.vptr>, !cir.vptr | ||
// CIR-NEXT: %[[DTOR_PTR:.*]] = cir.vtable.get_virtual_fn_addr %[[VPTR]][0] : !cir.vptr -> !cir.ptr<!cir.ptr<!cir.func<(!cir.ptr<!rec_A>)>>> | ||
// CIR-NEXT: %[[DTOR:.*]] = cir.load align(8) %[[DTOR_PTR]] : !cir.ptr<!cir.ptr<!cir.func<(!cir.ptr<!rec_A>)>>>, !cir.ptr<!cir.func<(!cir.ptr<!rec_A>)>> | ||
// CIR-NEXT: cir.call %[[DTOR]](%[[THIS]]) : (!cir.ptr<!cir.func<(!cir.ptr<!rec_A>)>>, !cir.ptr<!rec_A>) -> () | ||
// CIR-NEXT: cir.trap | ||
// CIR-NEXT: } | ||
tommymcm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
this->~A(); | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.