Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the docs configurations #34

Merged
merged 2 commits into from
May 28, 2024
Merged

update the docs configurations #34

merged 2 commits into from
May 28, 2024

Conversation

HarshCasper
Copy link
Member

No description provided.

Copy link

github-actions bot commented May 26, 2024

🎊 PR Preview has been successfully built and deployed to https://localstack-snowflake-docs-preview-pr-34.surge.sh 🎊

@HarshCasper HarshCasper requested a review from whummer May 26, 2024 16:22
config.toml Outdated
@@ -54,14 +54,14 @@ anchor = "smart"
[services]
[services.googleAnalytics]
# Comment out the next line to disable GA tracking. Also disables the feature described in [params.ui.feedback].
id = "UA-101988473-1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could track Web activity as well here over time. Do you see an issue in re-using the same token here, shouldn't GA be able to distinguish that this is coming from a different side/domain..? 🤔 (not a blocker for now, though..)

@HarshCasper HarshCasper merged commit ec16fd2 into main May 28, 2024
2 checks passed
@HarshCasper HarshCasper deleted the updateconfig branch May 28, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants