Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64 save diagrams in server #118

Merged
merged 7 commits into from
Apr 5, 2025
Merged

64 save diagrams in server #118

merged 7 commits into from
Apr 5, 2025

Conversation

egenerse
Copy link
Collaborator

@egenerse egenerse commented Apr 4, 2025

Checklist

  • I linked PR with a related issue
  • I added multiple screenshots/screencasts of my UI changes

Motivation and Context

This PR completes #64

Description

Environment variables are used to increase port/host flexibility
this pr merges to share modal
New env variables are defined for handling connections
Standalone server side has typescript and javascript
A new router is created in server to get and set diagrams in persistence db
Keep server.ts simple

Steps for Testing

Create .env files for standalone/webapp and standalone/server. Check .env.examples files and create values
Create a diagram locally and edit it.
Click share in the navbar and select any option from there.
You should see a new toast message on the right side
Check if the URL is copied to your clipboard by pasting it any text
Open the share modal and recopy the URL anytime to share with other users

Screenshots

Screen.Recording.2025-04-04.at.17.59.12.mov
Screen.Recording.2025-04-04.at.18.16.17.mov

@egenerse egenerse requested a review from kurunbelemir April 4, 2025 16:18
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldnt create collaboration link when I clicked the button. Am I missing something in the setup?
image

@egenerse egenerse self-assigned this Apr 5, 2025
Base automatically changed from 60-add-share-modals to main April 5, 2025 07:00
Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have same issue after I created .env file and build an run.

image

Copy link
Collaborator

@kurunbelemir kurunbelemir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I created the .env files, everthing works.
Endpoints are tested with postman.
Good work.

@egenerse egenerse merged commit 0d1291f into main Apr 5, 2025
2 of 3 checks passed
@egenerse egenerse deleted the 64-save-diagrams-in-server branch April 5, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants