97 add docker and GitHub workflow #98
Draft
+2,021
−1,976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know when this PR is ready for review via Slack. I will not necessarily respond to request review from GitHub. It's also still in a draft state so I don't know what to do with it |
egenerse
reviewed
Feb 20, 2025
Comment on lines
+46
to
+48
| "@emotion/react": "^11.14.0", | ||
| "@emotion/styled": "^11.14.0", | ||
| "html2canvas": "^1.4.1" |
There was a problem hiding this comment.
dependencies version should be a fixed number, you should remove ^ from the beginning.
Why do we need html2canvas here?
egenerse
reviewed
Feb 20, 2025
|
|
||
| services: | ||
| webapp: | ||
| image: "ghcr.io/ls1intum/apollon2/apollon2:${IMAGE_TAG}" |
There was a problem hiding this comment.
if we use GitHub container registry, should we keep scripts related to the docker hub? We don't need to also publish to the docker hub I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
Create a Github workflow for deployment.
Description
Steps for Testing
Screenshots