Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Toggle Channel Privacy #539

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

eylulnc
Copy link
Contributor

@eylulnc eylulnc commented Apr 4, 2025

Problem Description

Android app currently lacks the ability to toggle channel privacy, currently web app have this function.. Adding this option enables users to seamlessly switch between public and private channels, improving flexibility and access control.

Changes

The ability to toggle channel privacy has been added. This feature is integrated into the Channel Settings.
It allows switching a public channel to private and vice versa. I
nformative confirmation dialogs have also been implemented.

Steps for testing

1 user with moderation rights

Open course activated Channel

  • Create a new public channel (or use existing one ) and from channel setting toggle the privacy
  • Create a new private channel (or use existing one ) and from channel setting toggle the privacy

In each case should display a pop up to inform user about the changes that will be made. (See Screenshot)
And verify the privacy is toggled from public to private or vice versa

Screenshots

Screenshot 2025-04-03 at 22 16 28
Screenshot 2025-04-03 at 22 16 35

@eylulnc eylulnc self-assigned this Apr 4, 2025
@eylulnc eylulnc added the ready for review This PR can be reviewed label Apr 4, 2025
Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected, code lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants