Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking the way the warning is displayed #4

Conversation

mxgrey
Copy link

@mxgrey mxgrey commented Nov 22, 2024

Following the upstream discussion I started playing around with the way the warning gets displayed.

Here's where I settled after my own experimentation:

  • Pad the warning with lots of newlines so the warning doesn't get lost in the noise of the header
  • Push the $ to the right with a space to make it stand out a little better
  • Use a global variable so that the warning is only printed once, no matter how many ament-cargo packages are in the workspace

The resulting terminal output looks like this:
Screenshot from 2024-11-22 18-01-32

I'd prefer if it could be highlighted in yellow or red, but I think this is visible enough that users won't easily overlook it.

Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
@luca-della-vedova luca-della-vedova merged commit a49b149 into luca-della-vedova:luca/warn_cargo_ament Nov 25, 2024
1 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants