fix: Repair send transaction fields and add call and decoder #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
richtera
force-pushed
the
fix/repair-send-add-call
branch
from
5c199c8 to
358919f
Compare
CJ42
approved these changes
Apr 2, 2024
CJ42
reviewed
Apr 2, 2024
src/components/shared/ParamField.vue
Outdated
| import LSP4DigitalAsset from '@erc725/erc725.js/schemas/LSP4DigitalAsset.json' | ||
| import LSP9Vault from '@erc725/erc725.js/schemas/LSP9Vault.json' | ||
|
|
||
| const schemas = LSP3ProfileMetadata.concat(LSP4DigitalAsset, LSP9Vault) |
There was a problem hiding this comment.
Would suggest writing it as follow for readability (easier to see the schemas in there when they are written line by line. But not a big deal.
const schemas = [
...LSP3ProfileMetadata,
...LSP4DigitalAsset,
...LSP9Vault
]
src/components/shared/ParamField.vue
Outdated
| value = numberToHex(value) | ||
| } | ||
| const value = | ||
| typeof _value === 'string' && /^0x/.test(_value) |
There was a problem hiding this comment.
is it to test if it starts with?
Maybe it can be re-written like this?
Suggested change
| typeof _value === 'string' && /^0x/.test(_value) | |
| typeof _value === 'string' && _value.startsWith("0x") |
JeneaVranceanu
requested changes
Apr 2, 2024
JeneaVranceanu
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clickup
https://app.clickup.com/t/2645698/DEV-10497
Task
Repair SendTransaction panel
Add call button and call decoder.
Properly encoding bytes32 as a LSP data key if checkbox is on
Properly working with bytes and bytes32 arrays.
Allowing Call and allowing data conversion (here bytes) and LSP decoding (here LSP3Profile)