fix: mint amount calculation #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeneaVranceanu
force-pushed
the
fix/decimals-token-mint
branch
from
28ffbee to
cd3c80c
Compare
JeneaVranceanu
force-pushed
the
fix/decimals-token-mint
branch
from
ee663c2 to
ca4b7ed
Compare
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
|
@JeneaVranceanu @richtera - can we merge this one or are we missing something? |
|
Hugoo
approved these changes
Apr 16, 2024
|
@Hugoo Haha, yes, a review is missing. |
|
Thanks for your approval 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86by5jgxz
The current calculation of the mint amount always uses
toWeifunction which multiplies entered amount by 18.Not all LSP7 tokens have 18 decimals. This breaks minting.
Here is an attempt to mint 0x5f4030c46497ecf4340c7c9bca2412fa10536f08 which has 13 decimals.
The resulting value is not 1 but 1000000 tokens to be minted as 1 was converted using
toWeiand it produced an extra large value:After the fix with the same values: