Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new controller in list when setting permissions for new address #151

Merged
merged 17 commits into from
Apr 15, 2024

Conversation

CJ42
Copy link
Member

@CJ42 CJ42 commented Apr 10, 2024

  • Fix incorrect data key name for LSP8TokenIdType ❌ --> LSP8TokenIdFormat
  • Use plain RPC URL instead of provider for erc725.js instance

In the card for setting permissions, when this controller is a new controller, also add it in the list of controllers under AddressPermissions[].

image

@CJ42 CJ42 force-pushed the addControllerWithPermissions branch from 062e1a6 to 69fbf79 Compare April 10, 2024 22:37
@CJ42 CJ42 force-pushed the addControllerWithPermissions branch from fc85e1a to 4be6b77 Compare April 12, 2024 19:49
@CJ42 CJ42 force-pushed the addControllerWithPermissions branch from 9849b1f to 79e78ba Compare April 15, 2024 15:56
@CJ42 CJ42 force-pushed the addControllerWithPermissions branch from 79e78ba to 4d6319c Compare April 15, 2024 15:58
Copy link

@CJ42 CJ42 merged commit a7f6c62 into main Apr 15, 2024
1 check passed
@CJ42 CJ42 deleted the addControllerWithPermissions branch April 15, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants