-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new controller in list when setting permissions for new address #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CJ42
force-pushed
the
addControllerWithPermissions
branch
from
April 10, 2024 22:37
062e1a6
to
69fbf79
Compare
dzbo
approved these changes
Apr 11, 2024
frozeman
approved these changes
Apr 12, 2024
This reverts commit 3d6c432.
CJ42
force-pushed
the
addControllerWithPermissions
branch
from
April 12, 2024 19:49
fc85e1a
to
4be6b77
Compare
CJ42
force-pushed
the
addControllerWithPermissions
branch
from
April 15, 2024 15:56
9849b1f
to
79e78ba
Compare
CJ42
force-pushed
the
addControllerWithPermissions
branch
from
April 15, 2024 15:58
79e78ba
to
4d6319c
Compare
Deployed with Cloudflare Pages ☁️ 🚀 🆗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSP8TokenIdType
❌ -->LSP8TokenIdFormat
✅In the card for setting permissions, when this controller is a new controller, also add it in the list of controllers under
AddressPermissions[]
.