Fix build image #37
Fix build image #37
Conversation
|
@Trung-DV is attempting to deploy a commit to the Tushar Selvakumar's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe Dockerfile was modified to update the base image version from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM oven/bun:1.1.42 AS build-stage | |||
| FROM oven/bun:1.2 AS build-stage | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Pin the Bun image to an explicit version/digest for deterministic builds
Moving from oven/bun:1.1.42 to the floating tag 1.2 improves currency but sacrifices reproducibility—1.2 will resolve to different patch versions over time. Consider parametrising or digest-pinning the image so both stages always use the same, immutable base.
- FROM oven/bun:1.2 AS build-stage
+ARG BUN_VERSION=1.2.0 # or a SHA-256 digest
+FROM oven/bun:${BUN_VERSION} AS build-stage
…
- FROM oven/bun:1.2 AS serve-stage
+FROM oven/bun:${BUN_VERSION} AS serve-stageThis keeps the convenience of a single version declaration while guaranteeing identical builds and easing future upgrades (just bump BUN_VERSION).
Also applies to: 13-13
🏁 Script executed:
#!/bin/bash
# Search for all uses of the oven/bun image in the Dockerfile
rg "FROM oven/bun" -n DockerfileLength of output: 105
Pin the Bun base image for reproducible builds
Using the floating tag 1.2 risks pulling different patch releases over time. Pin to an exact version or digest so both stages remain immutable:
• Dockerfile, lines 1 & 13
Suggested diff:
+ ARG BUN_VERSION=1.2.0 # or a SHA256 digest
FROM oven/bun:1.2 AS build-stage
- FROM oven/bun:1.2 AS build-stage
+ FROM oven/bun:${BUN_VERSION} AS build-stage
…
- FROM oven/bun:1.2 AS serve-stage
+ FROM oven/bun:${BUN_VERSION} AS serve-stageThis centralizes the version declaration and guarantees identical builds—and future upgrades only require bumping BUN_VERSION.
🤖 Prompt for AI Agents
In Dockerfile lines 1 and 13, the Bun base image is referenced with a floating
tag "1.2", which can lead to inconsistent builds. To fix this, define a build
argument or environment variable for the exact Bun version or digest at the top
of the Dockerfile, then use this variable in both FROM statements to pin the
image version. This ensures reproducible builds and simplifies future version
upgrades by changing the version in a single place.
|
@Trung-DV can you pin it to the latest version: 1.2.19 |
Signed-off-by: Trung-DV <TrungDV.PMB@gmail.com>
I have updated @macintushar. While working on building the image, I found that the Supabase environment variables will be hardcoded into the static files, which cannot be modified when running |
Facing issue:
File .../src/routeTree.gen.ts was modified by another process during processingduring docker build like #31, but it's able to build when update bun version.After build, the
src/routeTree.gen.tswas also updatedSummary by CodeRabbit