Implement XDG Base Directory Specification support #63
Conversation
unrealapex
force-pushed
the
xdg-compliance
branch
from
4721cdc to
11638d6
Compare
unrealapex
changed the title
unrealapex
force-pushed
the
xdg-compliance
branch
from
11638d6 to
2b1c544
Compare
unrealapex
force-pushed
the
xdg-compliance
branch
from
2b1c544 to
c64e016
Compare
unrealapex
force-pushed
the
xdg-compliance
branch
3 times, most recently
from
ac33b94 to
b3d10b3
Compare
unrealapex
force-pushed
the
xdg-compliance
branch
from
42f70bc to
d6afeb5
Compare
unrealapex
changed the title
unrealapex
force-pushed
the
xdg-compliance
branch
from
d6afeb5 to
ba910b7
Compare
|
It appears there is some unintended errors in the tests resulting from local configuration. Would you please be able to look into why the tests are behaving like this and also update them to work with the new configuration file locations? I have "Allow edits by maintainers" enabled so you should be able to push commits to my fork. summary.logLinux sakura 6.10.11-gentoo-dist #1 SMP PREEMPT_DYNAMIC Wed Sep 18 18:49:44 -00 2024 x86_64 Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz GenuineIntel GNU/Linux Sat Sep 28 01:29:52 PDT 2024 =============
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:78: startup: -cl, short option, with profile %%% START: startup-y.tst:84: startup: -cl, long option, with profile % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:84: startup: -cl, long option, with profile %%% START: startup-y.tst:90: startup: -ci +m, short option, with rcfile % standard error diff: %%% FAILED: startup-y.tst:90: startup: -ci +m, short option, with rcfile %%% START: startup-y.tst:96: startup: -ci +m, long option, with rcfile % standard error diff: %%% FAILED: startup-y.tst:96: startup: -ci +m, long option, with rcfile %%% START: startup-y.tst:103: startup: -cil +m, short option, with profile/rcfile % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:103: startup: -cil +m, short option, with profile/rcfile %%% START: startup-y.tst:110: startup: -cil +m, long option, with profile/rcfile % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:110: startup: -cil +m, long option, with profile/rcfile %%% START: startup-y.tst:118: startup: -cil +m --noprofile % standard error diff: %%% FAILED: startup-y.tst:118: startup: -cil +m --noprofile %%% START: startup-y.tst:124: startup: -cil +m --norcfile % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:124: startup: -cil +m --norcfile %%% START: startup-y.tst:132: startup: -cl with unset HOME % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:132: startup: -cl with unset HOME %%% START: startup-y.tst:137: startup: -ci +m with unset HOME % standard error diff: %%% FAILED: startup-y.tst:137: startup: -ci +m with unset HOME %%% START: startup-y.tst:145: startup: -cl with non-existing HOME % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:145: startup: -cl with non-existing HOME %%% START: startup-y.tst:150: startup: -ci +m with non-existing HOME % standard error diff: %%% FAILED: startup-y.tst:150: startup: -ci +m with non-existing HOME %%% START: startup-y.tst:197: startup: -ci +m, LOADPATH fallback for missing yashrc % standard error diff: %%% FAILED: startup-y.tst:197: startup: -ci +m, LOADPATH fallback for missing yashrc %%% START: startup-y.tst:218: startup: -ci +m, no LOADPATH fallback if ~/.yashrc found % standard error diff: %%% FAILED: startup-y.tst:218: startup: -ci +m, no LOADPATH fallback if ~/.yashrc found %%% START: startup-y.tst:250: errors in profile % standard output diff: % standard error (expecting non-empty output):
xauth: (stdin):1: bad display name "sakura:1" in "add" command X.Org X Server 1.21.1.13 Current version of pixman: 0.43.4 %%% FAILED: startup-y.tst:250: errors in profile %%% START: startup-y.tst:260: errors in rcfile % standard output diff: % standard error (expecting non-empty output): %%% FAILED: startup-y.tst:260: errors in rcfile %%% START: startup-y.tst:272: startup: -abCcefhluvx %%% FAILED: startup-y.tst:272: startup: -abCcefhluvx %%% START: startup-y.tst:277: startup: -abCefhlsuvx %%% FAILED: startup-y.tst:277: startup: -abCefhlsuvx %%% START: startup-y.tst:364: hyphen prefix enables interactive mode (w/o directory name) % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:364: hyphen prefix enables interactive mode (w/o directory name) %%% START: startup-y.tst:372: hyphen prefix enables interactive mode (with directory name) % standard error diff:
+xauth: (stdin):1: bad display name "sakura:1" in "add" command
%%% FAILED: startup-y.tst:372: hyphen prefix enables interactive mode (with directory name) ==============
|
| @@ -48,7 +48,8 @@ variable to a different value. Please consult your OS's documentation to learn | |||
| how to configure these variables in detail. | |||
|
|
|||
| If you want to apply the same configuration every time you start yash, write | |||
| the command in ~/.yashrc or ~/.yash_profile. | |||
| the command in $XDG_CONFIG_HOME/yash/rc or $XDG_CONFIG_HOME/yash/profile. The old locations | |||
| ~/.yashrc and ~/.yash_profile are also supported as a fallback. | |||
There was a problem hiding this comment.
I feel that this could have been worded better, however, I do not have a specific way I would like this explanation to be worded in mind.
There was a problem hiding this comment.
Strange or not, all the tests pass on my end. Assuming the error is specific to your environment, I guess we should add XDG_CONFIG_HOME to the list of environment variables that are removed before running tests.
Co-authored-by: WATANABE Yuki <magicant@wonderwand.net>
unrealapex
force-pushed
the
xdg-compliance
branch
from
ba910b7 to
2b2f102
Compare
|
LGTM! Thank you for making my first contribution to this project so smooth! |
|
Great! Thank you so much! |
TODO
XDG_CONFIG_HOMEXDG_STATE_HOME/yashCloses #19