Add a github runner for macOS builds. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiself
reviewed
Oct 24, 2024
| with: | ||
| name: godot-python-macos-universal | ||
| path: | | ||
| bin/**/* |
There was a problem hiding this comment.
Are these lines needed for macos?
There was a problem hiding this comment.
I suppose not...
I failed to check if those files were generated in the first place, though the python folder also looks suspiciously empty so that's probably the next thing I will have to take a look at.
|
I'm going to commit this as is so that we can see if macos builds are working for the other pull requests. Edit: tho maybe its not as simple as that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #26 to be merged.
It may still fail because the macOS runner runs on arm64, I believe. I do not have an arm macbook so I cannot test there; having the GH runner test for me is a good first step to getting arm compatibility.