Draft: Adopt wemake-python-styleguide #100
Conversation
| "flake8-type-checking==3.0.0", | ||
| "flake8-class-attributes-order==0.3.0", | ||
| "flake8-simplify==0.21.0" | ||
| "wemake-python-styleguide==1.3.0" |
There was a problem hiding this comment.
why you removed all dependencies?
There was a problem hiding this comment.
I though everything is included into wemake-python-styleguid, will double check
| @@ -12,7 +12,7 @@ class BaseClientMeta(ABCMeta): | |||
| specific attributes). | |||
| """ | |||
|
|
|||
| pass | |||
| __slots__ = () | |||
There was a problem hiding this comment.
It was a workaround because wemake-python-styleguide thinks empty classes are bad. I will remove it and ignore the error
| for _id in ids: | ||
| result.append(self._cache_data.pop(_id)) | ||
| deleted_records = [] | ||
| for id_ in ids: |
There was a problem hiding this comment.
hm, id_ is not very pythonic
maybe we can use identifier, opinions?
or maybe another name
| @@ -41,7 +41,7 @@ class ModelMetaclass(PydanticModelMetaclass): | |||
| """ | |||
|
|
|||
| def __new__(mcs, name, bases, namespace): | |||
| cls = super().__new__(mcs, name, bases, namespace) | |||
| target_cls = super().__new__(mcs, name, bases, namespace) | |||
There was a problem hiding this comment.
I guess it's better to name new_cls
| @@ -105,7 +105,7 @@ def save(self: _M) -> _M: | |||
| data returned from the database after the save operation. | |||
|
|
|||
| Returns: | |||
| (_M): The saved model instance, updated with data from the database (e.g., | |||
| (_Model): The saved model instance, updated with data from the database (e.g., | |||
There was a problem hiding this comment.
it complained that _M is too short... Initially I tought to change _M to _Model yet then decided to suppress the error since it does not make a lot of sense. WDYT?
There was a problem hiding this comment.
@darya-shynkevich but it seems that you change it only in docstring, we can change it but everywhere
| @@ -21,7 +22,7 @@ def test_delete(self, supabase_client: SupabaseClient, httpx_mock: 'HTTPXMock'): | |||
| httpx_mock.add_response( | |||
| method="DELETE", | |||
| url=httpx.URL('https://test.supabase.co/rest/v1/table_name', params={'id': 'eq.1', 'title': 'neq.test'}), | |||
| status_code=200, | |||
| status_code=HTTPStatus.OK, | |||
There was a problem hiding this comment.
hm, is there are any other constants?
like HTTP_200_OK or something?
There was a problem hiding this comment.
yep, it complained about magic numbers a lot, yet I think that it is ok to use magic numbers in tests, so I change 200 to HTTPStatus.OK because it make sense and left all other places untouched.
There was a problem hiding this comment.
@darya-shynkevich no, HTTPStatus is better than magic numbers, keep it like this
|
@darya-shynkevich I've been a bit busy, sorry, are you still in? |
closes #95