Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a type checking issue in my repository, similar to the one described in #4991 (comment) with
@mantine/modals/lib/index.d.mts
Which was then fixed in #5697
I couldn't get the paths workaround working, so to solve this locally I can
@mantine/modals/lib/index.d.mts
inpostinstall
script and it will rely on the non-module file@mantine/modals/lib/index.d.ts
.js
to exportsThis PR makes the change to do
2.
Tbh I don't really know what I'm doing, I suspect we don't want to do this because I believe it will also add
.js
to the non-module@mantine/modals/lib/index.d.ts
file which we probs don't want.Was hoping that @waweber might be able to help 🙏