Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal exports for node16 #7603

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

connorads
Copy link
Contributor

@connorads connorads commented Mar 18, 2025

I have a type checking issue in my repository, similar to the one described in #4991 (comment) with @mantine/modals/lib/index.d.mts
Which was then fixed in #5697

image

I couldn't get the paths workaround working, so to solve this locally I can

  1. Delete@mantine/modals/lib/index.d.mts in postinstall script and it will rely on the non-module file @mantine/modals/lib/index.d.ts
  2. Or, patch the file to add .js to exports
    image

This PR makes the change to do 2.
Tbh I don't really know what I'm doing, I suspect we don't want to do this because I believe it will also add .js to the non-module @mantine/modals/lib/index.d.ts file which we probs don't want.

Was hoping that @waweber might be able to help 🙏

@rtivital rtivital marked this pull request as ready for review March 23, 2025 10:13
@rtivital rtivital merged commit 7d6dbe3 into mantinedev:master Mar 23, 2025
1 check passed
@rtivital
Copy link
Member

Thanks!

@connorads
Copy link
Contributor Author

No problem!

I was hoping that @waweber might validate the solution 😅 But if you're happy with it then great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants