-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings to enable or disable some rules on demand #18
Add settings to enable or disable some rules on demand #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose adding documentation to README.md for these options.
analyzer/testdata/src/constructor_check/constructors_after_struct_methods.go
Outdated
Show resolved
Hide resolved
I updated it with the following:
|
FYI, I'm working on a refactor, I will open a PR after the merge of this one. |
amazing, looking forward to check it. If you approve this one we can merge it, I think all the points were resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but some elements will be refactored)
merged. I will wait for the refactor to release v0.2.0 |
This PR adds the possibility to enable or disable some "checks" in the
funcorder
linter.Right now the linter checks the following:
Constructors
are placed after struct declaration.Constructors
are placed before the struct's method declaration.But, I did not add 3 settings to enable/disable these checks, I only added two:
constructor-check
: Enable/Disable checks for bullet points 1 and 2.struct-method-check
: Enable/Disable checks for bullet point 3.Close #17
What do you guys think?
Work Pending: