-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add clsx, twMerge and cva to make css easier #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although cva is a tiny library, it's best to use in a SSR/SSG environment – your user probably doesn't need this JavaScript, especially for static components.
https://cva.style/docs/getting-started/variants#creating-variants 에서 언급한 부분인데 SSR/SSG에 사용하기 좋다고 되어있긴 하네요~!
a regular dependency (dependencies). Since the code is executed at runtime by the consumer. If you use SSR/SSG you could probably prevent this code from running on the client, but it would still run on the server at runtime/build time, respectively.
joe-bell/cva#200 (comment) 요 부분도 discussion에 있어용
but there's no harm in moving that to a server-side/static function if you're concerned
- rsc: react server component - cc: client component
2632f48
to
0c61cc3
Compare
문제: vscode에서 파일명의 대문자를 소문자로 변경한 후 git에 올렸더니, git에서 case 변경 인식을 못해서 github actions에서 lint error 발생 해결: git mv 커맨드를 이용해 파일명을 대문자에서 소문자로 변경하여 파일명 컨벤션 통일
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue Number
#2
Description
cn
으로 유틸화했습니다.cn
을 storybook에 적용해보았습니다.To Reviewers
cva
,cn
을 적용한button.tsx
위주로 보시면 될 것 같습니다.따라서 Suspense와 관련된 다음 부분은 주의 깊게 보지 않으셔도 될 것 같습니다.
spinner.tsx
,loading-indicator.tsx
는 Suspense의 fallback으로 사용합니다.data.ts
는<Suspense>
안에 들어갈 컴포넌트의 data fetch를 위해 만들었습니다.Cf. https://stackoverflow.com/questions/71002100/nextjs-prerender-error-works-fine-in-dev-breaks-in-build
Checklist
feat: add login page
)