Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix places data revalidation and slicing #160

Merged
merged 3 commits into from
Oct 4, 2024
Merged

fix: fix places data revalidation and slicing #160

merged 3 commits into from
Oct 4, 2024

Conversation

hee-suh
Copy link
Member

@hee-suh hee-suh commented Oct 4, 2024

Issue Number

Description

구현 내용 및 작업한 내용

  • server actions로 받아오는 places는 useFetch의 revalidate가 아니라 next fetch의 revalidateTag를 이용해 revalidate 해주었어요
  • places 슬라이싱이 올바르게 작동하게 했어요

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

@github-actions github-actions bot added the fix label Oct 4, 2024
@hee-suh hee-suh changed the title fix: fix: fix places data revalidation and slicing Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

The latest updates on your projects. Preview: https://vitamin-c-aesl36hse-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-10-04T12:28:16Z

@hee-suh hee-suh merged commit d3a4eaa into dev Oct 4, 2024
5 checks passed
@hee-suh hee-suh deleted the fix/fetching branch October 4, 2024 12:32
hee-suh added a commit that referenced this pull request Oct 4, 2024
* Fix: Divide component to avoid unnecessary rendering (#154)

* Style: 맵 관리 > 하단 잘리는 현상 수정 (#156)

* feat: improve ux (#158)

* Chore/fix typo 자잘한 수정이요 (#157)

* fix: fix places data revalidation and slicing (#160)

---------

Co-authored-by: Jaeseok <72875894+Pridesd@users.noreply.github.com>
Co-authored-by: 주병호 <kjcoco13@gmail.com>
hee-suh added a commit that referenced this pull request Oct 4, 2024
* fix: update likedUser of sliced placeList (#144)

* fix: update likedUser of sliced placeList

* fix: fix css of image inside link in carousel

* chore: update package-lock.json

* feat: update ai recommendation page (#147)

* feat: add ticket icon

* refactor: add props to reuse gpt-intro-modal

* feat: implement use-typewriter for typing effect

* feat: update ai recommendation page

- add api call to get ai recommendations
- update logic and design

* feat: use test API in dev and real API in prod

api.gpt.restaurants.recommend

* feat: improve recommendation available count logic

* refactor: make ai-recommendation as a file

* chore: remove 'AI봇의 추천 이유' temporary

* fix: update isFetching and isLoading logic

* feat: update ai-recommend asset from img to lottie

* feat: update ai-recommend-place-box

* fix: fix lint error

* feat: handle rounding number and empty data

* feat: update ui (#148)

* feat: update bottom sheet scroll

* feat: add map search button (feature in progress

* fix: add async keyword to server actions

* fix: prevent component from mount twice

* feat: make bottom sheet state change by offsetY
considering size as well as direction

* feat: update ai recommendation page (#147)

* feat: add ticket icon

* refactor: add props to reuse gpt-intro-modal

* feat: implement use-typewriter for typing effect

* feat: update ai recommendation page

- add api call to get ai recommendations
- update logic and design

* feat: use test API in dev and real API in prod

api.gpt.restaurants.recommend

* feat: improve recommendation available count logic

* refactor: make ai-recommendation as a file

* chore: remove 'AI봇의 추천 이유' temporary

* fix: update isFetching and isLoading logic

* feat: update ai-recommend asset from img to lottie

* feat: update ai-recommend-place-box

* fix: fix lint error

* feat: handle rounding number and empty data

* feat: make allowUserPosition update properly

* feat: improve ai recommendation page (#150)

* feat: make linear-gradient css work on footer

* fix: make gap visible only if suggestionKeywords

* fix: make usageCapReachedChat show suggestionKwrds

* feat: add gpt case for unauthorized user

* feat: stop lottie loop on recommendation page

* fix: limit width of footer on recommendation page

* feat: group profile (#146)

* feat: set inital design

* feat: set profile link

* feat: add blue color

* feat: set TasteRate

* feat: add differ api

* fix: fix initial rate

* feat: set initial-panel

* feat: add place item

* chore: change style

* feat: set profile

* feat: set update map id logic

* fix: lint error

* feat: set 스켈레톤

* refactor: add mapId

* feat: 맵아이디를 적용해보았어용

* feat: 더보기를 추가했어용

* feat: 더보기 버튼 디자인을 쌈@@뽕하게 바꿨어용

* fix: lint error

* feat: update copy of ai recommendation (#152)

* Fix: Divide component to avoid unnecessary rendering (#154)

* Style: 맵 관리 > 하단 잘리는 현상 수정 (#156)

* feat: improve ux (#158)

* feat: add storage for save reommendation chats

* feat: make avatar colors different for usernames

* Chore/fix typo 자잘한 수정이요 (#157)

* Refactor: Remove useless api

* Fix: wording

* fix: fix places data revalidation and slicing (#160)

* fix: revalidate server actions using revalidateTag

* fix: prevent rendering of all places

* fix: remove unused variables

* feat: add chef emoji for '흑백요리사' tag (#161)

---------

Co-authored-by: Jaeseok <72875894+Pridesd@users.noreply.github.com>
Co-authored-by: 주병호 <kjcoco13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant