-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update font and tailwindcss theme configuration #22
Conversation
The latest updates on your projects. Preview: https://vitamin-c-7kr6mpa19-poiu694s-projects.vercel.app
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
크~ fallback은 고민되긴 하는데 천천히 정해도 될 것 같네요! 디자인쪽이랑 얘기해보거나 일단 브라우저 기본 폰트쓰게 만드는 것도 좋을 것 같아여~
title: 'Create Next App', | ||
description: 'Generated by create next app', | ||
title: '꼬르륵', | ||
description: '전설의 보물섬으로 가는 맛집 지도', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
센스 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 오늘 논의사항에 파레트 확정여부 물어보고 색상 추가만 하면 될 것 같네요!
@@ -19,7 +17,9 @@ export default function RootLayout({ | |||
}>) { | |||
return ( | |||
<html lang="ko"> | |||
<body className={inter.className}>{children}</body> | |||
<body className={`${pretendard.className} ${pretendard.variable}`}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 여기에 pretendard.className
은 body 전역에 pretendard를 적용할 수 있는 tailwind 방법인가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next.js에서 제공하는 기능입니다~!
https://nextjs.org/docs/app/api-reference/components/font#classname
The latest updates on your projects. Preview: https://vitamin-c-pjml7p5gf-poiu694s-projects.vercel.app
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue Number
#21
Description
swap
으로 설정했습니다.)To Reviewers
20px
을 제외하고는 tailwind css에서 정의된 값들을 사용하고 있어서, 기존에24px
로 설정되어있던rounded-3xl
을20px
로 업데이트해주기만 했습니다.Checklist
feat: add login page
)