Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set SearchInput component #32

Merged
merged 9 commits into from
Jun 29, 2024
Merged

Conversation

Pridesd
Copy link
Contributor

@Pridesd Pridesd commented Jun 29, 2024

Issue Number

close#27

Description

검색 기능 사용을 위한 검색 입력 컴포넌트를 제작했습니다.

구현 내용 및 작업한 내용

  • 색상이 다른 두 가지 버전의 input을 구현했습니다.
  • input 우측에 아이콘 버튼을 사용할 수 있습니다.
  • 아이콘 버튼에 handler를 사용할 수 있습니다.

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • storybook 설정을 했으나 svg 에러로 인해 설정을 삭제했습니다.

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link

The latest updates on your projects. Preview: https://vitamin-c-q6zv6mopu-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-06-29T12:45:18Z

@Pridesd Pridesd changed the title Feature/set search input component feat: set SearchInput component Jun 29, 2024
Copy link

The latest updates on your projects. Preview: https://vitamin-c-gdf084dj7-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-06-29T13:53:39Z

Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Pridesd Pridesd merged commit 73177ce into main Jun 29, 2024
3 checks passed
@Pridesd Pridesd deleted the feature/set_SearchInput_component branch June 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants