Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toast component #38

Merged
merged 8 commits into from
Jul 4, 2024
Merged

feat: add toast component #38

merged 8 commits into from
Jul 4, 2024

Conversation

hee-suh
Copy link
Member

@hee-suh hee-suh commented Jun 29, 2024

Issue Number

#26

Description

구현 내용 및 작업한 내용

  • react-hot-toast를 이용하여 토스트를 구현하였습니다.

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

이제 토스트가 정상 작동합니다!

2024-07-03.11.57.17.mov

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link

The latest updates on your projects. Preview: https://vitamin-c-a7k8x320z-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-06-29T18:50:44Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-ka2siwlud-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-06-29T20:17:42Z

Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

github-actions bot commented Jul 3, 2024

The latest updates on your projects. Preview: https://vitamin-c-osgovku3r-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-03T12:56:46Z

Copy link

github-actions bot commented Jul 3, 2024

The latest updates on your projects. Preview: https://vitamin-c-idposxecr-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-03T14:42:02Z

- width를 유연하게 조절하기 위해서 toast container의 position을 'sticky'로 설정하니까, translateY 애니메이션으로 인해 스크롤바가 잠시 표시되는 이슈 발생
- toast의 maxWidth를 최대 viewport width - 2 * marginX로 설정해서 임시 해결
Copy link

github-actions bot commented Jul 3, 2024

The latest updates on your projects. Preview: https://vitamin-c-c55hmp8mp-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-03T14:55:59Z

Copy link

github-actions bot commented Jul 4, 2024

The latest updates on your projects. Preview: https://vitamin-c-64gu64twk-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-04T05:15:11Z

@hee-suh hee-suh merged commit c01943f into main Jul 4, 2024
3 checks passed
@hee-suh hee-suh deleted the feature/component-toast branch July 4, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants