Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set kakao share #56

Merged
merged 11 commits into from
Jul 15, 2024
Merged

feat: set kakao share #56

merged 11 commits into from
Jul 15, 2024

Conversation

Pridesd
Copy link
Contributor

@Pridesd Pridesd commented Jul 14, 2024

Issue Number

#55

Description

카카오톡 공유 기능을 만들었습니다.

구현 내용 및 작업한 내용

  • 카카오 공유 함수 제작
  • date변환 유틸에 locale 부여

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link

The latest updates on your projects. Preview: https://vitamin-c-qds48mm7d-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-14T07:18:26Z

Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~!!~!!! 짱귀

스크린샷 2024-07-14 오후 7 01 46

src/app/layout.tsx Show resolved Hide resolved
src/hooks/use-kakao-share.ts Outdated Show resolved Hide resolved
src/hooks/use-kakao-share.ts Outdated Show resolved Hide resolved
src/hooks/use-kakao-share.ts Show resolved Hide resolved
src/utils/date.ts Outdated Show resolved Hide resolved
Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link

The latest updates on your projects. Preview: https://vitamin-c-d5x4ttyvq-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-15T02:33:05Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-colqmvwda-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-15T02:35:02Z

description: `${formatDate(expiredDate)}까지 참여할 수 있어요`,
imageUrl: 'https://kr.object.ncloudstorage.com/korrk-image/korrk.png',
link: {
webUrl: `${window.location.protocol}//${window.location.host}/invitation?link=${inviteLinkToken}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 protocol이 빠졌었네요! ${window.location.protocol}//${window.location.host} 대신 ${window.location.origin}만 적어도 괜찮을 것 같네요 :D

Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!!

hamster

@Pridesd Pridesd merged commit b8d52e9 into main Jul 15, 2024
3 checks passed
@Pridesd Pridesd deleted the feature/set-kakao-share branch July 15, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants