Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set api and add bottomSheet, FilterModal #63

Merged
merged 20 commits into from
Jul 19, 2024

Conversation

Pridesd
Copy link
Contributor

@Pridesd Pridesd commented Jul 18, 2024

Issue Number

#58

Description

구현 내용 및 작업한 내용
api연동과 리스트뷰를 나타내는 바텀시트 작업, 필터 바텀 모달을 제작했습니다.

  • api연동
  • 지도 페이지 내 바텀 시트 작업
  • 필터 바텀 모달

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 필터 로직 때문에 지도 페이지가 상당히 비대해졌는데, 만약 분리하는 게 나을 것 같은 부분 말씀해주시면 감사하겠습니다.

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link

The latest updates on your projects. Preview: https://vitamin-c-55j0vp8x4-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-18T11:08:10Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-296rlgqy5-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-18T13:10:21Z

Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구두로 이야기 나눈 것들만 반영해주시면 될 것 같습니다~!
image

const { data: placeList } = await api.place.mapId.get(mapId)
setPlaces(placeList)
} catch (err) {
notify.error('예상치 못한 오류가 발생했습니다.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서버에서 주는 error.message 사용하기로 했던 것 같습니다!

Copy link

The latest updates on your projects. Preview: https://vitamin-c-1i6s19sye-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-18T15:06:24Z

@Pridesd Pridesd merged commit 2aa2a7a into main Jul 19, 2024
3 checks passed
@Pridesd Pridesd deleted the feature/set-api-at-map-page branch July 19, 2024 06:31
hee-suh pushed a commit that referenced this pull request Jul 19, 2024
* feat: add tag type and change placeId type

* feat: add filter icon

* feat: set filter button

* feat: add getTags and getMapData api

* fix: add /

* feat: set filter button

* chore: change type

* chore: add FilterButton

* chore: change root

* feat: set PlaceListBottomSheet

* feat: set FilterModalBody component

* feat: set bottomSheet, select filter modal

* fix build error

* feat: link setting

* fix: fix type

* chore: relocate function position

* chore: set displayName

* chore: change hashtag to tag

* chore: change tags location
hee-suh added a commit that referenced this pull request Jul 19, 2024
* feature: update storage values

- rename invitation-link to invite-code
- change storage of new-map-id and nickname from local storage to session storage

* feat: add api /maps and /maps/invite-links

* feat: implement invite page

- update boarding-pass components
    - match the api response structure
    - put onClick inside to make invited-boarding-pass available in the server component, invite/page

* fix: add 'use client' directive

* feat: search-result-page (#60)

* feat: setting page (#62)

* feat: set api and add bottomSheet, FilterModal (#63)

---------

Co-authored-by: polee <43488305+poiu694@users.noreply.github.com>
Co-authored-by: Jaeseok <72875894+Pridesd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants