Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make floating btn responsive & refactor map #70

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

hee-suh
Copy link
Member

@hee-suh hee-suh commented Jul 22, 2024

Issue Number

#58

Description

구현 내용 및 작업한 내용

  • 바텀 시트 CSS를 수정했습니다.
    • style에 지정한 height를 삭제해서 useMeasure에서 바텀 시트 높이를 정확하게 파악할 수 있게 했습니다.
    • window size의 3/4 지점까지만 확장(Expanded)되게 제한했습니다.
    • header 높이 및 padding을 수정했습니다.
  • floating GPS 버튼의 위치가 하단의 콘텐츠의 위치에 따라 움직이게 했습니다.
    • 이 작업을 하면서 map 관련 컴포넌트들을 리팩토링 했습니다.

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • TODO로 되어있는 것들은 재석님이 남겨주신 건데, feat: set map input modal #68 에서 user 정보 가져오는 작업 추가하면서 같이 작업해주셔도 좋을 것 같습니다~

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

@hee-suh hee-suh self-assigned this Jul 22, 2024
@hee-suh hee-suh requested review from poiu694 and Pridesd as code owners July 22, 2024 10:48
Copy link

The latest updates on your projects. Preview: https://vitamin-c-3yxovrocx-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-22T10:48:13Z

@hee-suh hee-suh force-pushed the feature/floating-gps-button branch from 8875cbf to f0c5e8a Compare July 22, 2024 11:30
Copy link

The latest updates on your projects. Preview: https://vitamin-c-424aem2ke-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-22T11:30:52Z

Copy link
Member

@poiu694 poiu694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

@Pridesd Pridesd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@hee-suh hee-suh merged commit 8a3a248 into main Jul 22, 2024
3 checks passed
@hee-suh hee-suh deleted the feature/floating-gps-button branch July 22, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants