Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set like api at map page and remove legacy #75

Merged
merged 11 commits into from
Jul 27, 2024
Merged

Conversation

Pridesd
Copy link
Contributor

@Pridesd Pridesd commented Jul 26, 2024

Description

지도 페이지 내 좋아요 기능과 사용하지 않는 부분 제거

구현 내용 및 작업한 내용

  • 사용하지 않는 부분 제거
  • 좋아요 기능 적용

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 낙관적 업데이트를 적용하고 싶은데 방법 조언 부탁드립니다!

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link

The latest updates on your projects. Preview: https://vitamin-c-4otsaytrh-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-26T14:20:50Z

@hee-suh hee-suh changed the title feat: set like api at map page and remove regacy feat: set like api at map page and remove legacy Jul 26, 2024
Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

낙관적 업데이트는 isLike를 state로 관리하고, handleClick이 실행될 때 바로 isLike의 상태를 변경해준 후, api 호출이 실패하면 catch 문에서 isLike의 상태를 원상복구해주면 될 것 같아요~!

src/components/place/place-map-popup.tsx Outdated Show resolved Hide resolved
src/app/map/[mapId]/place-list-bottom-sheet.tsx Outdated Show resolved Hide resolved
src/components/place/place-map-popup.tsx Outdated Show resolved Hide resolved
Copy link

The latest updates on your projects. Preview: https://vitamin-c-bxizexgil-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-07-27T01:49:54Z

Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@hee-suh hee-suh merged commit 8c22d40 into main Jul 27, 2024
3 checks passed
@hee-suh hee-suh deleted the feature/japboo branch July 27, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants