Better sanitization of styles. #1348
Open
+10
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more sanitization for style attributes. It turns out that style parsing is kind of wonky, and it seems that a newline in the style attribute will end a style specification even if it is inside a quotation mark. So this PR turns newlines into spaces in styles to avoid that, and alters the split parameters for
\mmlToken
to be more in line with the parsing of styles. It also removes some unnecessaryas OptionList
casting.