Skip to content

Update segments.md #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: live
Choose a base branch
from
Open

Update segments.md #783

wants to merge 1 commit into from

Conversation

bojana-z
Copy link

@bojana-z bojana-z commented Apr 8, 2024

Added sentence for segment value encoding

Description:

Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.

Review

Added sentence for segment value encoding
@sgiehl
Copy link
Member

sgiehl commented Apr 8, 2024

@bojana-z what is the reason for adding that? That page actually starts with This guide applies to core developers., so it should be clear this is not meant for normal users. Or were there any confusions?

@bojana-z
Copy link
Author

bojana-z commented Apr 8, 2024

@sgiehl there was some confusion with a customer. Matthieu suggested adding it to prevent similar support requests in the future.

@sgiehl
Copy link
Member

sgiehl commented Apr 8, 2024

Ah ok. Well I'm not sure if it might not make more sense to have a general message being displayed on all pages that they are viewing the developer docs, which are not meant to be used by normal users. Otherwise we might end up adding such a note to all pages over time...

@bojana-z
Copy link
Author

bojana-z commented Apr 9, 2024

I think that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants