Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust email template to add scrollable table #23180

Merged
merged 6 commits into from
Apr 9, 2025
Merged

Conversation

spludlow
Copy link
Contributor

@spludlow spludlow commented Mar 27, 2025

Description:

Use display: block and overflow-x: auto to make table scrollable. This means some other styles were updated to match. The other option was to use a <div/> surrounding the table, however divs are unsupported in Outlook prior to 2017 and may cause weirdness in other clients. Tested in the MailPit.

fixes #22362

Review

@spludlow spludlow requested a review from a team March 27, 2025 15:39
@spludlow spludlow added the Needs Review PRs that need a code review label Mar 27, 2025
@spludlow spludlow marked this pull request as ready for review March 27, 2025 20:42
@michalkleiner michalkleiner changed the title dev-18245 - adjust email template to add scrollable table Adjust email template to add scrollable table Apr 1, 2025
@michalkleiner
Copy link
Contributor

Test failures unrelated

@sgiehl sgiehl added this to the 5.4.0 milestone Apr 7, 2025
@michalkleiner michalkleiner merged commit 081a47a into 5.x-dev Apr 9, 2025
26 of 27 checks passed
@michalkleiner michalkleiner deleted the dev-18245 branch April 9, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

[Bug] HTML Email report for all websites dashboard is too wide
4 participants