Skip to content

Wait until channel read completes before decoding packet. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Wait until channel read completes before decoding packet. #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b66afaa
wait until channel read completes before decoding packet
wassup- Mar 13, 2021
44d9b0e
forward operations to next _ChannelInboundHandler in pipeline
wassup- Mar 13, 2021
c57f262
convert indentation to spaces
wassup- Mar 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions Sources/MQTT/MQTTChannelHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,32 +13,45 @@ final class MQTTChannelHandler: ChannelInboundHandler {

private let decoder: MQTTDecoder
weak var delegate: MQTTChannelHandlerDelegate?
private var packetData = Data()

init(decoder: MQTTDecoder = MQTTDecoder()) {
self.decoder = decoder
}

func channelRead(context _: ChannelHandlerContext, data: NIOAny) {
func channelRead(context: ChannelHandlerContext, data: NIOAny) {
defer { context.fireChannelRead(data) }

var buf = unwrapInboundIn(data)
if let bytes = buf.readBytes(length: buf.readableBytes) {
var data = Data(bytes)
do {
let packet = try decoder.decode(data: &data)
delegate?.didReceive(packet: packet)
} catch let error as DecodeError {
delegate?.didCatch(decodeError: error)
} catch {
// unhandled error
fatalError("Error while decoding packet data: \(error.localizedDescription)")
}
packetData.append(contentsOf: bytes)
}
}

func channelReadComplete(context: ChannelHandlerContext) {
defer { context.fireChannelReadComplete() }

var data = packetData
packetData = Data()

do {
let packet = try decoder.decode(data: &data)
delegate?.didReceive(packet: packet)
} catch let error as DecodeError {
delegate?.didCatch(decodeError: error)
} catch {
// unhandled error
fatalError("Error while decoding packet data: \(error.localizedDescription)")
}
}

func channelActive(context: ChannelHandlerContext) {
defer { context.fireChannelActive() }
delegate?.channelActive(channel: context.channel)
}

func channelInactive(context _: ChannelHandlerContext) {
func channelInactive(context: ChannelHandlerContext) {
defer { context.fireChannelInactive() }
delegate?.channelInactive()
}
}