Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Rich Accounts with mnemonic phrases #241

Merged
merged 2 commits into from
Dec 15, 2023
Merged

chore: Add Rich Accounts with mnemonic phrases #241

merged 2 commits into from
Dec 15, 2023
+140 −5

Conversation

MexicanAce
Copy link
Collaborator

@MexicanAce MexicanAce commented Dec 15, 2023 •
edited
Loading

What 💻

  • Add rich accounts with mnemonic phrases
  • Updated SUPPORTED_APIS

Why ✋

  • Test suites commonly rely on mnemonic phrases with things like foundry
  • Support is updated for eth_sendTransaction

Evidence 📷

This is what era_test_node run now looks like:
image

E2E tests still pass 👍
image

Notes 📝

  • I'm keeping the legacy rich wallets so that everything is still backwards compatible... I'm just not printing them out to the console

@MexicanAce MexicanAce requested a review from a team as a code owner December 15, 2023 19:47
@dutterbutter dutterbutter merged commit 7a4722f into main Dec 15, 2023
11 checks passed
@dutterbutter dutterbutter deleted the nmv/add-more-rich-accounts branch December 15, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MexicanAce @dutterbutter