Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move storage view, allow ignoring bootloader execution during tx execution #251

Merged
merged 15 commits into from
Dec 22, 2023
Merged

feat: move storage view, allow ignoring bootloader execution during tx execution #251

merged 15 commits into from
Dec 22, 2023
+336 −262

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Dec 22, 2023 •
edited
Loading

What 💻

  • Move storage view from zksync-era
  • Add capability to exclude bootloader execution when running raw txs

Why ✋

  • Allow to make seamless changes to the storage under the hood
  • Executing bootloader doesn't make sense, because it doesn't execute any meaningful in terms of transaction execution, but it adds a lot of complexity

Evidence 📷

Tests pass for PR and in matter-labs/foundry-zksync#205

Notes 📝

Deniallugo and others added 12 commits December 13, 2023 13:18
@Deniallugo
move storage view to test node
61d04e2 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Update era
bc43d87 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
add modified keys and do not execute bootloader
618ac51 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Load l1 batch from local
fbe272e 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Update era
a44b974 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Merge branch 'main' into deniallugo-move-storage-view
d527b98
@Deniallugo
Fix nits
5e7dea4 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Adapt tests
d91f3f9 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Introduce bool
fde67c7 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Update era
f06f672 
Signed-off-by: Danil <deniallugo@gmail.com>
@Deniallugo
Merge branch 'main' into deniallugo-move-storage-view
e233b35
@nbaztec
remove modified keys
2934a9c
@nbaztec nbaztec requested a review from a team as a code owner December 22, 2023 14:43
@nbaztec nbaztec mentioned this pull request Dec 22, 2023
Merged
@MexicanAce MexicanAce merged commit 6ee7d29 into matter-labs:main Dec 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutterbutter dutterbutter dutterbutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbaztec @dutterbutter @MexicanAce @Deniallugo