Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Port test-node to most recent core revision #284

Merged
merged 1 commit into from
May 16, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented May 16, 2024

What πŸ’»

  • Ports test node to the most recent core revision.

Why βœ‹

  • Several breaking changes were made in core APIs, so this is to make further maintenance of the node easier.
  • Note this sweet minus 1868 lines in the Cargo.lock. Nice, innit?

Evidence πŸ“·

You got to trust me this time.

@popzxc popzxc requested a review from a team as a code owner May 16, 2024 07:47
@popzxc popzxc requested a review from MexicanAce May 16, 2024 08:02
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce
Copy link
Collaborator

MexicanAce commented May 16, 2024

Note this sweet minus 1868 lines in the Cargo.lock. Nice, innit?

πŸ™Œ Praise be

You got to trust me this time.

We have unit and e2e tests for changes like this πŸ˜„

@MexicanAce MexicanAce merged commit 7ed3e5d into main May 16, 2024
10 checks passed
@MexicanAce MexicanAce deleted the popzxc-zksync-core-is-no-more branch May 16, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants