-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: L2 gas price change #285
Merged
Merged
+17
β17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦t_in_without_security_mode
MexicanAce
reviewed
May 20, 2024
Thank you π ! Confirmed that it worked for $ era_test_node replay_tx sepolia-testnet 0x488c598ad0d6f1135bd61e5bce494be6b79a17deebd1d09a700da7dddde2efde
15:38:32 INFO Creating fork from "https://sepolia.era.zksync.dev:443" L1 block: L1BatchNumber(8933) L2 block: 2327751 with timestamp 1715775538, L1 gas price 52156830537 and protocol version: Some(Version24)
15:38:32 INFO Starting network with chain id: L2ChainId(300)
15:38:32 INFO Running 1 transactions (one per batch)
15:38:32 INFO
15:38:32 INFO Validating 0x488c598ad0d6f1135bd61e5bce494be6b79a17deebd1d09a700da7dddde2efde
15:38:32 INFO Executing 0x488c598ad0d6f1135bd61e5bce494be6b79a17deebd1d09a700da7dddde2efde
15:38:38 INFO βββββββββββββββββββββββββββ
15:38:38 INFO β TRANSACTION SUMMARY β
15:38:38 INFO βββββββββββββββββββββββββββ
15:38:38 INFO Transaction: SUCCESS
15:38:38 INFO Initiator: 0xe85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38 INFO Payer: 0xe85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38 INFO Gas - Limit: 1_919_764 | Used: 944_441 | Refunded: 975_323
15:38:38 INFO Use --show-gas-details flag or call config_setShowGasDetails to display more info
15:38:38 INFO
15:38:38 INFO ==== Console logs:
15:38:38 INFO
15:38:38 INFO ==== 23 call traces. Use --show-calls flag or call config_setShowCalls to display more info.
15:38:38 INFO
15:38:38 INFO ==== 4 events
15:38:38 INFO EthToken System Contract
15:38:38 INFO Topics:
15:38:38 INFO 0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38 INFO 0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38 INFO 0x0000000000000000000000000000000000000000000000000000000000008001
15:38:38 INFO Data (Hex): 0x0000000000000000000000000000000000000000000000000000534165da4324
15:38:38 INFO
15:38:38 INFO EthToken System Contract
15:38:38 INFO Topics:
15:38:38 INFO 0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38 INFO 0x0000000000000000000000000000000000000000000000000000000000008001
15:38:38 INFO 0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38 INFO Data (Hex): 0x000000000000000000000000000000000000000000000000000025b8ded2d2e4
15:38:38 INFO
15:38:38 INFO EthToken System Contract
15:38:38 INFO Topics:
15:38:38 INFO 0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38 INFO 0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38 INFO 0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38 INFO Data (String):
15:38:38 INFO
15:38:38 INFO EthToken System Contract
15:38:38 INFO Topics:
15:38:38 INFO 0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef
15:38:38 INFO 0x0000000000000000000000000000000000000000000000000000000000008001
15:38:38 INFO 0x000000000000000000000000e85b66fca403bc35bcae17ce7758e942aea65dc0
15:38:38 INFO Data (Hex): 0x0000000000000000000000000000000000000000000000000000172204ec65f0 |
MexicanAce
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What π»
Halved
L2_GAS_PRICE
to 25000000 and changed the fee model to match.Why β
Replaying some Sepolia transactions didn't work with the original value.
Evidence π·
Both unit and e2e tests pass.