Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MySQL version to 8.0 #668

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Bump MySQL version to 8.0 #668

merged 2 commits into from
Jan 11, 2024

Conversation

agnivade
Copy link
Member

@agnivade agnivade added the 2: Dev Review Requires review by a core committer label Nov 20, 2023
@agnivade
Copy link
Member Author

Strangely, this still creates a 5.7 instance. Need to investigate some more.

@agnivade
Copy link
Member Author

Woops my bad, I changed the param group, not the engine version. 🤦 Monday morning.

Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@agnivade
Copy link
Member Author

@agarciamontoro - Wondering if @DHaussermann should give this a quick smoke test just to ensure there is no regression?

Copy link
Member

@agarciamontoro agarciamontoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Thanks, Agniva 🎉 And yes, we should test this similarly to how we tested the Postgres bump in #590

family = var.db_instance_engine == "aurora-mysql" ? "aurora-mysql5.7" : "aurora-postgresql12"
family = var.db_instance_engine == "aurora-mysql" ? "aurora-mysql8.0" : "aurora-postgresql12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, huh, the one for postgres should have been aurora-postgresql14 🤔

@agarciamontoro agarciamontoro added the 3: QA Review Requires review by a QA tester label Nov 20, 2023
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Nov 21, 2023
@agnivade
Copy link
Member Author

agnivade commented Dec 5, 2023

Closing for now. To be reopened on Feb 2024.

@agnivade agnivade closed this Dec 5, 2023
@agnivade agnivade reopened this Jan 9, 2024
@agnivade
Copy link
Member Author

agnivade commented Jan 9, 2024

Reopening this now! FYI @agarciamontoro @streamer45

@agarciamontoro
Copy link
Member

@agnivade, next step here would be for @DHaussermann to test it, or is there anything else we need to do before that?

@agnivade
Copy link
Member Author

agnivade commented Jan 9, 2024

Yep, nothing else needed.

Copy link
Contributor

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agnivade everything seem normal with the Load testing process.

  • The deployments have changes as expected.
    image
  • The deployed instance seem to function normally and I could see the regular activity from the load test as expected
    image
  • The data generated in Graphana for both bounded and unbounded seems typical
    image

No issues found LGTM!

I couldn't think of a simple way to benchmark the MySql versions against each other. As this is configured at the Terraform level, both base and new will always use the same version of MySql. @agarciamontoro, am I mistaken? I feel like I did this for Postgres once a few months ago but, can't recall how.
Also, I understand that comparing performance was not the goal here but I was curious on if there are appreciable performance improvements.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jan 11, 2024
@agnivade
Copy link
Member Author

Thanks Dylan!

@agnivade agnivade merged commit 88df7c5 into master Jan 11, 2024
2 checks passed
@agnivade agnivade deleted the bumpMySQL branch January 11, 2024 16:54
@agarciamontoro
Copy link
Member

I couldn't think of a simple way to benchmark the MySql versions against each other. As this is configured at the Terraform level, both base and new will always use the same version of MySql. @agarciamontoro, am I mistaken? I feel like I did this for Postgres once a few months ago but, can't recall how.

A late answer, sorry, but here it goes: the only way is to run both tests independently and then manually generate a report for each of them (with report generate) and compare them (with report compare). It's what the comparison sub-command makes automatically, but you'd need to do it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants