-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MySQL version to 8.0 #668
Conversation
Strangely, this still creates a 5.7 instance. Need to investigate some more. |
Woops my bad, I changed the param group, not the engine version. 🤦 Monday morning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
@agarciamontoro - Wondering if @DHaussermann should give this a quick smoke test just to ensure there is no regression? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo! Thanks, Agniva 🎉 And yes, we should test this similarly to how we tested the Postgres bump in #590
family = var.db_instance_engine == "aurora-mysql" ? "aurora-mysql5.7" : "aurora-postgresql12" | ||
family = var.db_instance_engine == "aurora-mysql" ? "aurora-mysql8.0" : "aurora-postgresql12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, huh, the one for postgres should have been aurora-postgresql14
🤔
Closing for now. To be reopened on Feb 2024. |
Reopening this now! FYI @agarciamontoro @streamer45 |
@agnivade, next step here would be for @DHaussermann to test it, or is there anything else we need to do before that? |
Yep, nothing else needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agnivade everything seem normal with the Load testing process.
- The deployments have changes as expected.
- The deployed instance seem to function normally and I could see the regular activity from the load test as expected
- The data generated in Graphana for both bounded and unbounded seems typical
No issues found LGTM!
I couldn't think of a simple way to benchmark the MySql versions against each other. As this is configured at the Terraform level, both base and new will always use the same version of MySql. @agarciamontoro, am I mistaken? I feel like I did this for Postgres once a few months ago but, can't recall how.
Also, I understand that comparing performance was not the goal here but I was curious on if there are appreciable performance improvements.
Thanks Dylan! |
A late answer, sorry, but here it goes: the only way is to run both tests independently and then manually generate a report for each of them (with |
https://mattermost.atlassian.net/browse/MM-55589