Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-1121]: Fix epic selector not displaying options if field is renamed in Jira #1134

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[MM-1121]: Fix epic selector not displaying options if field is renamed in Jira #1134

wants to merge 4 commits into from

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Nov 5, 2024 •
edited
Loading

Summary

  • The Create Issue modal had a bug: if the Epic field in a Jira project was renamed to anything other than Epic, the dropdown for selecting Jira epics displayed no options.
  • The existing logic iterates over each field in the Jira project, filtering for fields named Epic, and then checks if the filtered field matches the Epic field schema before fetching all epics from the project.
  • The bug occurred because the code depended solely on finding a field named Epic. This PR removes the name-based check and instead relies exclusively on the field schema to identify the Epic field.

Ticket Link

Fixes #1121

What to test

  • Create different fields of epic type in a Jira project
  • Look for the Epic link field in the Create Issue modal

Screenshot from 2024-11-05 13-54-22

@Kshitij-Katiyar Kshitij-Katiyar added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 5, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Nov 5, 2024
@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Nov 6, 2024
Closed
raghavaggarwal2308
raghavaggarwal2308 requested changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@raghavaggarwal2308 raghavaggarwal2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper QA testing steps. As the QA will not know about renaming the fields on Jira side.

webapp/src/components/data_selectors/jira_epic_selector/jira_epic_selector.tsx Outdated Show resolved Hide resolved
webapp/src/components/data_selectors/jira_epic_selector/jira_epic_selector.tsx Outdated Show resolved Hide resolved
webapp/src/components/data_selectors/jira_epic_selector/jira_epic_selector.tsx Show resolved Hide resolved
@Kshitij-Katiyar
Copy link
Contributor Author

Please add proper QA testing steps. As the QA will not know about renaming the fields on Jira side.

No need to rename the field, added the link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 Awaiting requested review from wiggin77 wiggin77 is a code owner

@avas27JTG avas27JTG Awaiting requested review from avas27JTG

At least 1 approving review is required to merge this pull request.

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Epic Link field show no options if Epic are renamed
2 participants
@Kshitij-Katiyar @raghavaggarwal2308